Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Injecting the ToC into Yao docs #284

Merged
merged 38 commits into from Jun 24, 2021
Merged

Injecting the ToC into Yao docs #284

merged 38 commits into from Jun 24, 2021

Conversation

VarLad
Copy link
Contributor

@VarLad VarLad commented Jun 8, 2021

No description provided.

@VarLad
Copy link
Contributor Author

VarLad commented Jun 8, 2021

@Roger-luo
Copy link
Member

This looks good in general, but the layout is a bit strange - can we have both the sidebar and Toc centerized instead of only centerize the content?

@VarLad
Copy link
Contributor Author

VarLad commented Jun 20, 2021

Isn't it already centralized?
I just removed the numbers and the scroll line though

Look here again https://varlad.github.io/Yao.jl/dev/man/base.html

@VarLad
Copy link
Contributor Author

VarLad commented Jun 20, 2021

Also, sorry for the late response, strange that Github didn't notify me.... 😅

@Roger-luo
Copy link
Member

Yeah this does look better, I think I'll just merge this for now. The right TOC bar still looks a bit strange to me, perhaps it's because of the position. But we can improve this later.

@Roger-luo Roger-luo merged commit 3030fb0 into QuantumBFS:master Jun 24, 2021
@VarLad
Copy link
Contributor Author

VarLad commented Jun 29, 2021

I think it looks strange because the ToC at the left is not centralized

So.... maybe we should place the ToC in the right to far right too?

Screenshot from 2021-06-29 13-45-07

@VarLad
Copy link
Contributor Author

VarLad commented Jun 29, 2021

Opinions are welcome
Github is not notifying me about any of this so thats strange....

Again, sorry for the late response 😅

@VarLad
Copy link
Contributor Author

VarLad commented Jun 29, 2021

........Google was marking all my github notifications as Spam.... 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants