Skip to content
This repository has been archived by the owner on Dec 18, 2021. It is now read-only.

fix julia 1.2 compiling issue. #29

Merged
merged 3 commits into from
Aug 30, 2019
Merged

fix julia 1.2 compiling issue. #29

merged 3 commits into from
Aug 30, 2019

Conversation

GiggleLiu
Copy link
Member

#28
Fix this compiling issue.

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #29 into master will increase coverage by 0.37%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   79.67%   80.04%   +0.37%     
==========================================
  Files           8        8              
  Lines         487      481       -6     
==========================================
- Hits          388      385       -3     
+ Misses         99       96       -3
Impacted Files Coverage Δ
src/instruct.jl 95.36% <100%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f84314...d60b4f7. Read the comment docs.

@Roger-luo
Copy link
Member

can you change travis config in this PR?

@GiggleLiu
Copy link
Member Author

I changed the way we dispatch, now the code is less... Good to merge? @Roger-luo

@Roger-luo Roger-luo merged commit 7cdb707 into master Aug 30, 2019
@Roger-luo Roger-luo deleted the fixjuliav1.2 branch September 24, 2019 23:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants