Skip to content
This repository has been archived by the owner on Dec 18, 2021. It is now read-only.

add support for symbolic #31

Merged
merged 2 commits into from
Sep 24, 2019
Merged

add support for symbolic #31

merged 2 commits into from
Sep 24, 2019

Conversation

Roger-luo
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 24, 2019 •
edited
Loading

Codecov Report

Merging #31 into master will increase coverage by 0.36%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #31      +/-   ##
=========================================
+ Coverage   80.04%   80.4%   +0.36%     
=========================================
  Files           8       8              
  Lines         481     490       +9     
=========================================
+ Hits          385     394       +9     
  Misses         96      96
Impacted Files Coverage Δ
src/instruct.jl 95.36% <100%> (ø) ⬆️
src/operations.jl 85.71% <90%> (+10.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cdb707...de87cbb. Read the comment docs.

GiggleLiu
GiggleLiu reviewed Sep 24, 2019
View reviewed changes
test/operations.jl
@test statevec(reg3) == onehot(ComplexF64, nbit, 4) + onehot(ComplexF64, nbit, 0)
@test statevec(reg3 |> normalize!) == (onehot(ComplexF64, nbit, 4) + onehot(ComplexF64, nbit, 0))/sqrt(2)
@test (reg1 + reg2 - reg1) == reg2
@test reg1' + reg2' - reg1' == reg2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also add tests for Number * reg', reg' * number, isnormalized(reg'), normalize!(reg'), -reg'

@GiggleLiu
Copy link
Member

Please add more tests, the change looks fine.

@codecov-io
Copy link

codecov-io commented Sep 24, 2019 •
edited by codecov bot
Loading

Codecov Report

Merging #31 into master will increase coverage by 0.36%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #31      +/-   ##
=========================================
+ Coverage   80.04%   80.4%   +0.36%     
=========================================
  Files           8       8              
  Lines         481     490       +9     
=========================================
+ Hits          385     394       +9     
  Misses         96      96
Impacted Files Coverage Δ
src/instruct.jl 95.36% <100%> (ø) ⬆️
src/operations.jl 85.71% <90%> (+10.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cdb707...de87cbb. Read the comment docs.

@GiggleLiu GiggleLiu merged commit b165866 into master Sep 24, 2019
@Roger-luo Roger-luo deleted the symbolic branch September 24, 2019 23:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GiggleLiu GiggleLiu GiggleLiu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Roger-luo @GiggleLiu @codecov-io