Skip to content
This repository has been archived by the owner on Dec 18, 2021. It is now read-only.

Remove data type parameter from AbstractArray #15

Merged
merged 2 commits into from
Aug 2, 2019
Merged

Conversation

GiggleLiu
Copy link
Member

Remove data type parameter from AbstractArray
Note: This is a breaking change.

@GiggleLiu GiggleLiu changed the title Fix rmregtype Remove data type parameter from AbstractArray Aug 1, 2019
@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #15 into master will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage    56.2%   56.42%   +0.21%     
==========================================
  Files          11       11              
  Lines         258      257       -1     
==========================================
  Hits          145      145              
+ Misses        113      112       -1
Impacted Files Coverage Δ
src/adjoint_register.jl 83.33% <ø> (ø) ⬆️
src/abstract_register.jl 8% <ø> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe4ea78...e7c622a. Read the comment docs.

Copy link
Member

@Roger-luo Roger-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to have other

@Roger-luo Roger-luo merged commit e7fa2d9 into master Aug 2, 2019
@Roger-luo Roger-luo added the break breaking change label Aug 2, 2019
@Roger-luo
Copy link
Member

version is updated in master.

@Roger-luo Roger-luo deleted the fix-rmregtype branch October 9, 2019 06:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
break breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants