conversion between YaoIR and ZXDiagram for pure quantum #41

ChenZhao44 · 2020-06-30T06:26:55Z

YaoIR to ZXDiagram
ZXDiagram to YaoIR

Roger-luo · 2020-07-01T22:38:03Z

src/compiler/zx_calculus.jl

    return ir
 end

+function to_YaoIR(circ::ZXDiagram{T, P}) where {T, P}


you could just define a constructor of YaoIR here.

This function only generates an IR not a YaoIR. It should be renamed.

but you reused some code from YaoIR constructor. It'd be better to make this either a constructor of YaoIR or a constructor for IR. to_<node> convention is used specifically for the parser side in YaoLang.

Roger-luo · 2020-07-01T22:39:17Z

src/compiler/zx_calculus.jl

+        return
+    end
+    lowered_ast = Meta.lower(@__MODULE__, ex)
+    ir = mark_quantum(IRTools.IR(lowered_ast.args[], 0))


this could segment fault, if you don't update slots.

mark quantum is not necessary here if you construct the YaoIR object body directly from an empty IR object

Empty IR has no register and return. So I use these codes for generating them.

you can push! these two argument as a statement and branch to IR. This will cause a lot extra work and make the compilation slow.

Roger-luo · 2020-07-01T22:41:04Z

src/compiler/zx_calculus.jl

+        $(Expr(:meta, :register, :new, gensym(:register)))
+        return
+    end
+    lowered_ast = Meta.lower(@__MODULE__, ex)


you don't have to go through the parser again. you can use IR() to construct an empty IR object directly, and then insert SSA statements.

Roger-luo · 2020-07-01T22:43:19Z

test/compiler/zx_calculus.jl

@@ -1,6 +1,7 @@
 using YaoLang
 using YaoLang.Compiler
-using YaoLang.Compiler: device_m, enable_timings, timings
+using YaoLang.Compiler: to_ZX_diagram, to_YaoIR, optimize!, clifford_simplify!
+using IRTools

 include("../../../ZXCalculus/script/zx_plot.jl")


remember to remove this.

Roger-luo · 2020-07-01T22:44:08Z

Project.toml

@@ -6,6 +6,7 @@ version = "0.2.1"
 [deps]
 ExprTools = "e2ba6199-217a-4e67-a87a-7c52f15ade04"
 IRTools = "7869d1d1-7146-5819-86e3-90919afe41df"
+LightGraphs = "093fc24a-ae57-5d10-9952-331d41423f4d"


If we only need push_gate! functions from ZXCalculus, shouldn't we only need the dependency of ZXCalculus here?

I suggest we move what should be inside ZXCalculus first, or updating it would require a 2nd major version update.

LightGraphs is needed because we need neighbors(zxd, v) here.

Roger-luo · 2020-07-02T04:56:07Z

src/compiler/zx_calculus.jl

+        for q = 1:nqubit
+            if frontier_v[q] <= length(lo.spider_seq[q])
+                v = lo.spider_seq[q][frontier_v[q]]
+                nb = neighbors(circ, v)


you can just export neighbors from ZXCalculus.

or simply use ZXCalculus.neighbors

Roger-luo · 2020-07-02T05:01:22Z

src/compiler/zx_calculus.jl

@@ -1,14 +1,72 @@
-using ZXCalculus
+using ZXCalculus, LightGraphs
+using ZXCalculus: qubit_loc

 function optimize!(ir::YaoIR)


optimize! should use a compiler context to dispatch optimize methods, since zx calculus won't be the only optimization strategy and can be disabled in a low optimization context. I'll rewrite this part later.

Roger-luo · 2020-07-25T02:52:10Z

@device optimize=[:zx_clifford, :zx_teleport] function circuit()
end

Roger-luo · 2020-08-01T02:28:40Z

src/compiler/zx_calculus.jl

@@ -0,0 +1,167 @@
+using ZXCalculus
+using ZXCalculus: qubit_loc, clifford_simplification
+import IRTools: IR


don't use import, if you need to overload a function write it explicitly IRTools.IR

Roger-luo · 2020-08-01T02:31:39Z

src/compiler/zx_calculus.jl

+        end
+        new_ir = YaoIR(ir.mod, ir.name, ir.args, ir.whereparams, IR(circ),
+            ir.quantum_blocks, ir.pure_quantum, ir.qasm_compatible)
+        return new_ir


https://github.com/QuantumBFS/YaoLang.jl/blob/master/src/compiler/ir.jl#L50

ChenZhao44 added 4 commits June 29, 2020 22:13

conversion from YaoIR to ZXDiagram for pure quantum

e6cfb41

add deps

45bd1de

ZXDiagram to YaoIR

35ad76f

rm println

d383a54

ChenZhao44 changed the title ~~conversion from YaoIR to ZXDiagram for pure quantum~~ conversion between YaoIR and ZXDiagram for pure quantum Jul 1, 2020

ChenZhao44 requested a review from Roger-luo July 1, 2020 09:01

Roger-luo reviewed Jul 1, 2020

View reviewed changes

Roger-luo reviewed Jul 2, 2020

View reviewed changes

Roger-luo and others added 12 commits July 3, 2020 01:07

Merge branch 'master' into simplification

ed05d1f

add keyword config

81d0090

fix construction of new IR

5582733

rename conversion functions

0d0d724

fix test

15e19ac

Merge branch 'master' into simplification

d019bf8

rm LightGraphs

f081b1a

Merge branch 'master' into simplification

17df3e2

add manifest

aa387a1

add manifest

e55b6b0

fix phase teleportation

a2667a1

rm println

7635a99

Roger-luo mentioned this pull request Jul 13, 2020

How to visualize/manipulate in Julia? QuantumBFS/ZXCalculus.jl#38

Closed

ChenZhao44 added 2 commits July 17, 2020 14:59

pi

e56f901

clifford_simplification

26563e0

ChenZhao44 added 5 commits July 25, 2020 16:23

add args for choosing optimizor

8cfa7bc

fix the case when an args is a vector of Symbols

28611e5

add test for zx_calculus

0aaab8a

fix CI

aa4a518

correct spelling of optimizer

b054a7b

Roger-luo reviewed Aug 1, 2020

View reviewed changes

add update_slot!

f78876a

Roger-luo merged commit a279099 into master Aug 30, 2020

Roger-luo deleted the simplification branch August 30, 2020 02:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

conversion between YaoIR and ZXDiagram for pure quantum #41

conversion between YaoIR and ZXDiagram for pure quantum #41

ChenZhao44 commented Jun 30, 2020 •

edited

Roger-luo Jul 1, 2020

ChenZhao44 Jul 2, 2020

Roger-luo Jul 2, 2020

Roger-luo Jul 1, 2020

Roger-luo Jul 1, 2020

ChenZhao44 Jul 2, 2020

Roger-luo Jul 2, 2020

Roger-luo Jul 1, 2020

Roger-luo Jul 1, 2020

Roger-luo Jul 1, 2020

Roger-luo Jul 1, 2020

ChenZhao44 Jul 2, 2020 •

edited

Roger-luo Jul 2, 2020

Roger-luo Jul 2, 2020

Roger-luo Jul 2, 2020

Roger-luo commented Jul 25, 2020

Roger-luo Aug 1, 2020

Roger-luo Aug 1, 2020

conversion between YaoIR and ZXDiagram for pure quantum #41

conversion between YaoIR and ZXDiagram for pure quantum #41

Conversation

ChenZhao44 commented Jun 30, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChenZhao44 Jul 2, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Roger-luo commented Jul 25, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ChenZhao44 commented Jun 30, 2020 •

edited

ChenZhao44 Jul 2, 2020 •

edited