Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an IR for quantum circuits #53

Merged
merged 52 commits into from
Sep 4, 2020
Merged

Add an IR for quantum circuits #53

merged 52 commits into from
Sep 4, 2020

Conversation

ChenZhao44
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #53 into master will increase coverage by 1.41%.
The diff coverage is 93.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage   90.65%   92.06%   +1.41%     
==========================================
  Files          13       14       +1     
  Lines        1337     1488     +151     
==========================================
+ Hits         1212     1370     +158     
+ Misses        125      118       -7     
Impacted Files Coverage Δ
src/ZXCalculus.jl 100.00% <ø> (ø)
src/qcircuit.jl 92.51% <92.51%> (ø)
src/circuit_extraction.jl 86.62% <100.00%> (+10.34%) ⬆️
src/simplify.jl 100.00% <100.00%> (ø)
src/zx_diagram.jl 97.18% <100.00%> (+0.03%) ⬆️
src/zx_graph.jl 84.35% <100.00%> (+0.08%) ⬆️
src/rules.jl 96.17% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b256777...7a45835. Read the comment docs.

src/qcircuit.jl Outdated Show resolved Hide resolved
src/qcircuit.jl Outdated Show resolved Hide resolved
@ChenZhao44
Copy link
Member Author

The current implementation of the global phase doesn't support symbolic variables. And it will also make the ZXDiagram mutable.

@Roger-luo
Copy link
Member

I think I'll merge this first. But there are still a few things we should think about. It's very likely that we prefer to move gate decomposition to YaoLang at some point, given it's not about ZXCalculus and we would want to support more gates. On the other hand, I think a primitive gate set that is allowed in ZX Calculus needs to be defined at some point, so we limit the functionality of this IR.

@Roger-luo Roger-luo merged commit 91a316a into master Sep 4, 2020
@Roger-luo Roger-luo deleted the qcircuit branch September 4, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants