Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change storage to Dict #9

Merged
merged 9 commits into from
May 18, 2020
Merged

change storage to Dict #9

merged 9 commits into from
May 18, 2020

Conversation

ChenZhao44
Copy link
Member

No description provided.

@Roger-luo
Copy link
Member

CI is not pass, we should just remove the dependency of Multigraph for now, since we are going to make a custom one for fast development

@Roger-luo
Copy link
Member

I think you forget to remove Multigraph in tests. And one small comment on this: usually we should use a separate PR to remove things like deps, files etc. so it appears in the PR review process more clearly.

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #9 into master will decrease coverage by 18.23%.
The diff coverage is 57.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #9       +/-   ##
===========================================
- Coverage   38.98%   20.74%   -18.24%     
===========================================
  Files           9        8        -1     
  Lines         531      429      -102     
===========================================
- Hits          207       89      -118     
- Misses        324      340       +16     
Impacted Files Coverage Δ
src/Multigraphs/multigraph_adjlist.jl 57.83% <ø> (+57.83%) ⬆️
src/ZX.jl 100.00% <ø> (ø)
src/zx_graph.jl 0.00% <ø> (-70.00%) ⬇️
src/zx_diagram.jl 46.55% <57.57%> (-12.38%) ⬇️
src/rules.jl 0.00% <0.00%> (-84.36%) ⬇️
src/Multigraphs/multiple_edge.jl 19.35% <0.00%> (+19.35%) ⬆️
src/Multigraphs/abstract_multigraph.jl 23.33% <0.00%> (+23.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec15f8d...e7a1def. Read the comment docs.

@Roger-luo Roger-luo closed this May 18, 2020
@Roger-luo Roger-luo reopened this May 18, 2020
@Roger-luo Roger-luo merged commit ad64e37 into master May 18, 2020
@Roger-luo Roger-luo linked an issue May 18, 2020 that may be closed by this pull request
4 tasks
@Roger-luo Roger-luo mentioned this pull request May 18, 2020
@ChenZhao44 ChenZhao44 deleted the Dict branch May 22, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add adjacent list based multigraph
2 participants