Fix Search Bug and Update Libraries #591
Conversation
|
Great, thank you! Any chance this could be tied to the existing NSFW preference please? https://github.com/QuantumBadger/RedReader/blob/master/src/main/res/xml/prefs_behaviour.xml#L158 Some people may have NSFW enabled on their account, but disabled in the app (because you don't necessarily want it enabled on the bus :)) Also I assume this works if someone is logged out? It looks like the build is failing due to the gradle wrapper change -- please could you fix the |
|
The NSFW preference will prevent NSFW results showing up, even with this enabled, so we shouldn't need to tie this to the NSFW preference. |
|
Looks like the build is still failing. It's saying licenses have not been accepted. I'm not sure how to fix that. |
|
I think the https://github.com/QuantumBadger/RedReader/blob/master/.travis.yml It tells Travis which SDKs to download, and it's still stuck on the old versions. |
|
I updated .travis and it looks like it's still failing. |
|
Travis still seems to be downloading the wrong SDK -- maybe it checked out the wrong commit somehow. Restarting the build didn't help. Would you mind adding another commit to the pull request please? Just something minor like an extra newline somewhere, to hopefully make Travis detect the latest commit? If that doesn't work I'll probably just merge this and fix any actual issues which crop up. |
|
Alright, pushed |
|
Perfect, thanks, looks like it's working now :) I'll get this merged in. |
|
Changelog updated: |
|
Alpha 156 built. |
I noticed that searches would not include nsfw results, even if
show nsfw contentwas enabled. This seems to be due to an undocumented API change requiring a cookie for searches to return nsfw results. I've implemented this with the okhttp backend. I have also updated the SDK version to 27.