Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QPD-1207 #140

Merged
merged 3 commits into from Sep 17, 2021
Merged

QPD-1207 #140

merged 3 commits into from Sep 17, 2021

Conversation

niharp2
Copy link
Contributor

@niharp2 niharp2 commented Sep 17, 2021

changes to pass query_params dict in api calls for edge_connectors.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Sep 17, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.14%.

Quality metrics Before After Change
Complexity 0.41 ⭐ 0.40 ⭐ -0.01 👍
Method Length 23.86 ⭐ 24.07 ⭐ 0.21 👎
Working memory 4.49 ⭐ 4.42 ⭐ -0.07 👍
Quality 91.13% 91.27% 0.14% 👍
Other metrics Before After Change
Lines 140 142 2
Changed files Quality Before Quality After Quality Change
quartic_sdk/_version.py 100.00% ⭐ 100.00% ⭐ 0.00%
quartic_sdk/api_client.py 90.89% ⭐ 91.05% ⭐ 0.16% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@niharp2 niharp2 merged commit adf76f0 into develop Sep 17, 2021
@niharp2 niharp2 deleted the QPD-1207 branch September 17, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants