Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StepMania Map Conversion #154

Merged
merged 13 commits into from
May 14, 2024

Conversation

WilliamQiufeng
Copy link
Contributor

@WilliamQiufeng WilliamQiufeng commented Apr 6, 2024

This PR improves the conversion of StepMania maps in the following way:

  • Don't repeatedly use addition on floating point numbers to improve precision
  • Fix BPM and Stop changes when they are between two rows of notes
  • Add SV for stops

@WilliamQiufeng WilliamQiufeng marked this pull request as draft April 7, 2024 02:05
@WilliamQiufeng WilliamQiufeng marked this pull request as ready for review April 7, 2024 04:38
@WilliamQiufeng WilliamQiufeng changed the title Fix StepMania BPM change when beat is a fraction Fix StepMania Map Conversion Apr 7, 2024
@WilliamQiufeng
Copy link
Contributor Author

I have changed the focus of this PR to improving SM conversion overall. You can test the following maps as an example:

Hatsune Miku's Head Exercises.zip

@Cinammon Roll.zip

PS CodeFactor wants me to put parenthesis in a + b * c. Should I really do that??

@Emik03
Copy link
Member

Emik03 commented May 7, 2024

I have changed the focus of this PR to improving SM conversion overall. You can test the following maps as an example:

Hatsune Miku's Head Exercises.zip

@Cinammon Roll.zip

PS CodeFactor wants me to put parenthesis in a + b * c. Should I really do that??

I don't think it's necessary to add parentheses, but I do recommend rearranging it to b * c + a to make it read more organically.

@Warp9000 Warp9000 merged commit bf369dd into Quaver:master May 14, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants