Merge pull request #2601 from Swan/recalc-local-scores

Recalculate performance rating of outdated local scores
Quaver · Aug 27, 2020 · 497223b · 497223b
2 parents cd9801a + 249b69e
commit 497223b
Show file tree

Hide file tree

Showing 4 changed files with 49 additions and 0 deletions.
diff --git a/Quaver.Shared/Database/Scores/Score.cs b/Quaver.Shared/Database/Scores/Score.cs
@@ -195,6 +195,11 @@ public class Score
         /// </summary>
         public double RankedAccuracy { get; set; }
 
+        /// <summary>
+        ///     The version of the difficulty calculator used for this score
+        /// </summary>
+        public string DifficultyProcessorVersion { get; set; }
+
         /// <summary>
         ///     If the score is an online score.
         /// </summary>

diff --git a/Quaver.Shared/Database/Scores/ScoreDatabaseCache.cs b/Quaver.Shared/Database/Scores/ScoreDatabaseCache.cs
@@ -93,6 +93,22 @@ internal static int InsertScoreIntoDatabase(Score score)
             return -1;
         }
 
+        /// <summary>
+        ///     Updates an individual map in the database.
+        /// </summary>
+        public static void UpdateScore(Score score)
+        {
+            try
+            {
+                DatabaseManager.Connection.Update(score);
+                Logger.Debug($"Updated score: {score.Id} in the cache", LogType.Runtime);
+            }
+            catch (Exception e)
+            {
+                Logger.Error(e, LogType.Runtime);
+            }
+        }
+
         /// <summary>
         ///     Responsible for removing a score from the database
         /// </summary>

diff --git a/Quaver.Shared/Screens/Results/ResultsScreen.cs b/Quaver.Shared/Screens/Results/ResultsScreen.cs
@@ -7,6 +7,7 @@
 using Microsoft.Xna.Framework.Input;
 using Quaver.API.Enums;
 using Quaver.API.Helpers;
+using Quaver.API.Maps.Processors.Difficulty.Rulesets.Keys;
 using Quaver.API.Maps.Processors.Rating;
 using Quaver.API.Maps.Processors.Scoring;
 using Quaver.API.Maps.Processors.Scoring.Data;
@@ -687,6 +688,7 @@ private void SubmitLocalScore(GameplayScreen screen, Replay replay)
                 screen.PauseCount, screen.Map.RandomizeModifierSeed, JudgementWindowsDatabaseCache.Selected.Value);
 
             // Calculate performance rating
+            score.DifficultyProcessorVersion = DifficultyProcessorKeys.Version;
             score.RatingProcessorVersion = RatingProcessorKeys.Version;
             score.PerformanceRating = processor.Failed ? 0 : new RatingProcessorKeys(Map.DifficultyFromMods(processor.Mods)).CalculateRating(rankedAccuracy);
             score.RankedAccuracy = rankedAccuracy;

diff --git a/Quaver.Shared/Screens/Selection/UI/Leaderboard/Rankings/ScoreFetcherLocal.cs b/Quaver.Shared/Screens/Selection/UI/Leaderboard/Rankings/ScoreFetcherLocal.cs
@@ -1,6 +1,9 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using Quaver.API.Enums;
+using Quaver.API.Maps.Processors.Difficulty.Rulesets.Keys;
+using Quaver.API.Maps.Processors.Rating;
 using Quaver.Shared.Database.Maps;
 using Quaver.Shared.Database.Scores;
 using Quaver.Shared.Screens.Select.UI.Leaderboard;
@@ -18,6 +21,29 @@ public FetchedScoreStore Fetch(Map map)
             try
             {
                 var scores = ScoreDatabaseCache.FetchMapScores(map.Md5Checksum);
+
+                if (map.DifficultyProcessorVersion == DifficultyProcessorKeys.Version)
+                {
+                    foreach (var score in scores)
+                    {
+                        if (score.DifficultyProcessorVersion == DifficultyProcessorKeys.Version)
+                            continue;
+
+                        score.DifficultyProcessorVersion = DifficultyProcessorKeys.Version;
+                        score.RatingProcessorVersion = RatingProcessorKeys.Version;
+                        var oldRating = score.PerformanceRating;
+
+                        var diff = map.DifficultyFromMods((ModIdentifier) score.Mods);
+                        var rating = new RatingProcessorKeys(diff).CalculateRating(score.Accuracy, score.Grade == Grade.F);
+
+                        score.PerformanceRating = rating;
+                        ScoreDatabaseCache.UpdateScore(score);
+
+                        Logger.Important($"Rating of score: {score.Id} recalculated to {score.PerformanceRating} from {oldRating}",
+                            LogType.Runtime, false);
+                    }
+                }
+
                 return new FetchedScoreStore(scores, scores?.Count != 0 ? scores?.First() : null);
             }
             catch (Exception e)