Merge pull request #4161 from WilliamQiufeng/fix-tournament-players-n…

…ullref Initialize TournamentScreenView.TournamentPlayers before the guard in TournamentScreenView.CreateOverlay to avoid NullReferenceException
Quaver · Jun 1, 2024 · ab19485 · ab19485
2 parents 2702872 + 3f988f8
commit ab19485
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/Quaver.Shared/Screens/Tournament/TournamentScreenView.cs b/Quaver.Shared/Screens/Tournament/TournamentScreenView.cs
@@ -251,11 +251,11 @@ private void CreateUsernames()
         /// </summary>
         private void CreateOverlay()
         {
+            TournamentPlayers = new List<TournamentPlayer>();
+
             if (TournamentScreen.GameplayScreens.Count > 2 || !ConfigManager.Display1v1TournamentOverlay.Value)
                 return;
 
-            TournamentPlayers = new List<TournamentPlayer>();
-
             // Create overlay for spectator
             if (OnlineManager.CurrentGame != null)
             {