Improved premature return to MultiplayerGameScreen on GameEnd #4092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new field, Force, is added to GameEnded packet, which indicates whether the game is force-ended. Only returns to the screen when !mp end is sent or lobby is disband (latter situation won't happen in tournaments)
WilliamQiufeng
force-pushed
the
improved-premature-game-end
branch
from
9ca80e8
to
9186077
Compare
AiAe
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only returns to the screen when all players have not finished playing the map (not when the spectator has not finished the replay).
This method does not rely on timing threshold, i.e. the game screen exits if we're more than 10sec before ending and the GameEnded packet is received. Instead, it now needs all players to have not finished the map before !mp end is called.
The following mapset is modified so that the notes in the first 20 seconds are removed. It could be used as a testing map.
II-L - Unidentified Frequency Op.3 (Type-Triangle) - 147332 - 副本.zip