2d solver A matrix. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Unit test for dx_dxi added.
- Currently the difference between the dx_dxi and dx_dxi_reference is maximum of 1e-8.
- Threshold should be less than 1e-14 because both the derivatives were calculated analyticaly.
- csv_to_numpy functions added.
… bugfix. - Unit tests for 2d_wave_equation derivative functions added. [PASSING] - utils.csv_to_numpy was using a hardcoded filename instead of using the `filename` argument. Bug fixed.
- tests/2d_wave_equation renamed - dg_maxwell/tests/2d_wave_equation/files/* added to .gitignore.
…tion_2d - test_2d_wave_equation renamed to test_wave_equation_2d. - gitignore modified following the renaming - dg_maxwell/tests/2d_wave_equation/files/circle.msh added.
- Documentation added and checked. - Unit test not written.
- Documentation written.
…3.5 was required.
…3.5 was required.
- Now it checks the memory location of the passed variables. If it matches, then both the variables are allocated a new memory.
- Documented. - Algo not properly documented - Unit test written - Example written Issues - Unit test for test_wave_equation_2d.py::test_A_matrix and test_waveEqn.py::test_volume_integral_flux FAILING when using opencl as backend. Works fine on cpu and cuda backend.
- coveralls badge for quazartech:DG_Maxwell:master added in README'
|
Changes Unknown when pulling 55aa39b on amanabt:2d_solver_A_matrix into ** on QuazarTech:master**. |
- The reference values being calculated using the LGL points with accuracy of 1e-4, whereas, the unit test was using LGL points with accuracy of machine error. The difference in accuracy of the LGL points lead to huge errors b/w reference and test A matrix. - The bug is fixed.
|
Changes Unknown when pulling 8fb5302 on amanabt:2d_solver_A_matrix into ** on QuazarTech:master**. |
|
Changes Unknown when pulling 8fb5302 on amanabt:2d_solver_A_matrix into ** on QuazarTech:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of function for calculation of A matrix for 2D wave equation solver.
Known issues
Checklist: