api/admin: fix backup exclude #202
Conversation
rustybird
force-pushed
the
backup-exclude
branch
from
6e5237f
to
becfd7f
Compare
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
==========================================
- Coverage 55.53% 55.51% -0.03%
==========================================
Files 56 56
Lines 9035 9035
==========================================
- Hits 5018 5016 -2
- Misses 4017 4019 +2
Continue to review full report at Codecov.
|
| # handle exclude | ||
| vms_to_backup.difference_update(vm for vm in self.app.domains | ||
| if any(qubes.utils.match_vm_name_with_special(vm, name) | ||
| for name in exclude_vms)) |
There was a problem hiding this comment.
This is wrong, because exclude_vms argument is expected to be a list of VM names, but exclude in backup profile may also contain special keywords like @tag:something. Probably the easiest thing to do is to construct exclude list based on all VMs here (like it is here right now), but save it into exclude_vms instead of applying directly to vms_to_backup.
There was a problem hiding this comment.
Sorry, fixed!
test_621_qdb_vm_with_network is racy BTW.
rustybird
force-pushed
the
backup-exclude
branch
2 times, most recently
from
8fa784e
to
45d1567
Compare
Bugfix on 59abdeb
rustybird
force-pushed
the
backup-exclude
branch
from
45d1567
to
a0c5014
Compare
Bugfix on 59abdeb