Fixing issue 9011: DNS leakage when only one DNS server is set #505
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #505 +/- ##
=======================================
Coverage 70.57% 70.57%
=======================================
Files 3 3
Lines 469 469
=======================================
Hits 331 331
Misses 138 138 ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024062200-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024062115-4.3&flavor=update
Failed tests8 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/103633#dependencies 6 fixed
Unstable tests
|
This looks to be broken by this PR. After suspend Yet, DNS in sys-net is set: My guess is the extra |
The ifindex 0 is to fetch the final DNS construction based on the of DNS values of all network interfaces according to their static or dynamic DHCP settings as well as their connection status. That is what ends in the systemd-resolved generated But for the time, removing I suggest a new Unit Test for further investigation. Put the system in sleep mode, Change upstream network parameters (DNS, Gateway, DHCP lease range, ...) , Then resume from sleep. The sys-net of the virtual machine should be able to connect to new upstream and apply the settings to have connectivity. |
|
@alimirjamali can you please reword the commit message? Remove |
Done. Is it OK now? |
|
Yes, thank you. |
Add netvm reconnect to the test. This is mostly to test if DNS forwarding gets properly updated on dynamic network attach too. Suggested at QubesOS/qubes-core-agent-linux#505 (comment)
Add netvm reconnect to the test. This is mostly to test if DNS forwarding gets properly updated on dynamic network attach too. Suggested at QubesOS/qubes-core-agent-linux#505 (comment) (cherry picked from commit 14b5612)
Fixes QubesOS/qubes-issues#9011
Details in Github comments and forum link