Allow specifying a username in service config #109
Conversation
|
Fuzzer makefile needs an update. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2023092018-4.2&flavor=pull-requests New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.2&build=2023071104-4.2&flavor=update
Failed tests6 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/77326#dependencies 23 fixed
Unstable tests
|
|
PipelineRetry |
This is still the case: fuzzer fails to link: |
|
I may be missing something, but does it actually change the user used for the call? IIUC it only uses the |
DemiMarie
force-pushed
the
username-service-config
branch
from
49ab526
to
5ccb5d4
Compare
Codecov Report
@@ Coverage Diff @@
## main #109 +/- ##
=======================================
Coverage 85.09% 85.09%
=======================================
Files 31 31
Lines 5174 5174
=======================================
Hits 4403 4403
Misses 771 771
|
This still applies. |
|
DemiMarie
force-pushed
the
username-service-config
branch
from
5ccb5d4
to
ba51675
Compare
|
Every single test failed on setup with |
I’ll try installing in a StandaloneVM and see how things break. |
|
Any update on this? |
|
I’ll test this and see what goes wrong. |
DemiMarie
force-pushed
the
username-service-config
branch
2 times, most recently
from
c001c0c
to
3d9698a
Compare
DemiMarie
force-pushed
the
username-service-config
branch
from
3d9698a
to
01efcb5
Compare
|
There is a merge conflict now :( |
This allows the C compiler to type-check arguments to qrexec_log() and thus to the logging macros.
exit() will double-flush streams, among other problems.
This avoids crashes if a buggy qrexec agent sends a malformed message. It also avoids variable-length arrays (VLAs), which have been removed from Linux due to security concerns. Finally, it avoids storing the entire message on the stack, which makes stack overflows less likely. This is especially true on musl libc, which uses a much smaller default stack size.
This requires some internal refactoring, which is split off into a separate commit to ease reviewing.
DemiMarie
force-pushed
the
username-service-config
branch
from
01efcb5
to
6fc445c
Compare
This also dramatically improves the configuration parser. Configuration files now use a strict subset of TOML rather than an ad-hoc format with no validation. Fixes: QubesOS/qubes-issues#6354 Fixes: QubesOS/qubes-issues#8153
They are a bad idea and the Linux kernel has banned them from its code.
DemiMarie
force-pushed
the
username-service-config
branch
from
6fc445c
to
0fa8ecc
Compare
This also dramatically improves the configuration parser. Configuration files now use a strict subset of TOML rather than an ad-hoc format with no validation.
Fixes: QubesOS/qubes-issues#6354
Fixes: QubesOS/qubes-issues#8153