Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module-vchan-sink: link up the card properly #107

Merged
merged 1 commit into from Aug 22, 2020

Conversation

mattmccutchen
Copy link
Contributor

Now the latency offset in pavucontrol works!

Addresses QubesOS/qubes-issues#1322.

I manually built the modified module-vchan-sink.so and hacked one AppVM to load it instead of the original, and it works. I haven't tried building RPMs, but I can't imagine that this small change would have a problem specific to the RPM build.

Now the latency offset in pavucontrol works!
@mattmccutchen
Copy link
Contributor Author

Here is my new GPG key for Qubes OS contributions: mattmccutchen-qubes-contributions.txt. (As explained here, I do not have a general-purpose GPG key at this time.) Do I need to do anything more before this key can be used, like submit a pull request to add it to signature-checker?

@mattmccutchen
Copy link
Contributor Author

It looks like the Travis CI check failure is unrelated to my change:

Error unpacking rpm package qubes-core-agent-4.1.15-1.fc32.x86_64
error: unpacking of archive failed on file /etc/fstab;5f402261: cpio: rename failed - No such file or directory
error: qubes-core-agent-4.1.15-1.fc32.x86_64: install failed

@marmarek
Copy link
Member

Thanks, I've uploaded your key to the signature-checker.

@marmarek marmarek merged commit 391160e into QubesOS:master Aug 22, 2020
@mattmccutchen
Copy link
Contributor Author

Thanks @marmarek! Since it may be a long time before Qubes 4.1 is released, would you be willing to apply this change to 4.0 as well? Let me know if I can help in some way. E.g., I could submit a pull request to the release4.0 branch, but I suspect it might be more work for you to review such a pull request than to just cherry-pick the commit yourself.

@marmarek
Copy link
Member

No problem, should be in 4.0.30, just pushed to build server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants