New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qubes Manager "restart VM" feature fails periodically #2362

Closed
andrewdavidwong opened this Issue Oct 4, 2016 · 1 comment

Comments

@andrewdavidwong
Member

andrewdavidwong commented Oct 4, 2016

Qubes OS version (e.g., R3.1):

R3.2

Problem description:

On 2016-10-04 04:38, cubit wrote:

Hello

I am testing the new "restart" feature in the Qubes VM Manager and noticing that it is a bit buggy. There is one piece of the puzzle however that I can not figure out allowing me to replicate it consistently or narrow down why it fail some times

The first time I select a VM and press "restart" after an indeterminate time frame the restart will fail with the error below. If I try and restart any number of other vm immediately after they will all restart ok.

error:

  ---
  line: assert not vm.is_running() 
  func: start_vm
  line no.: 1158
  file: /usr/lib64/python2.7/site-packages/qubesmanager/main.py
  ---
  line: self.caller.start_vm(vm)
  func: check_if_vm_has_shutdown
  line no.: 288
  file: /usr/lib64/python2.7/site-packages/qubesmanager/main.py

cubit

@cubi7

This comment has been minimized.

Show comment
Hide comment
@cubi7

cubi7 Oct 4, 2016

Some unscientific testing.

Trying a restart after 15 minutes of not doing a restart and the function works as expected

Trying a restart after 50 minutes of not doing a restart and the function fails the first time with the error as mentioned previously.

cubi7 commented Oct 4, 2016

Some unscientific testing.

Trying a restart after 15 minutes of not doing a restart and the function works as expected

Trying a restart after 50 minutes of not doing a restart and the function fails the first time with the error as mentioned previously.

marmarta added a commit to marmarta/qubes-manager that referenced this issue Jul 13, 2018

Fixed bug with starting a running VM in Qubes Manager
On some occasions (e.g., when restarting) Qubes Manager would try to
start a VM twice, and threw an error. Removed the assertion and instead
just happily accept that there's nothing to do when starting a running
VM.

fixes QubesOS/qubes-issues#2362

marmarta added a commit to marmarta/qubes-manager that referenced this issue Jul 13, 2018

Fixed VM name validation in GUI tools (Create VM, Settings, Manager)
VM name validation in various places in Manager did not allow a
perfectly legal '_' character.

references QubesOS/qubes-issues#2362

@marmarek marmarek closed this Jul 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment