New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qubes-dom0-update root.img handling bug #2848

Closed
tasket opened this Issue Jun 7, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@tasket

tasket commented Jun 7, 2017

Qubes OS version (e.g., R3.2):

R3.1, R3.2

Affected TemplateVMs (e.g., fedora-23, if applicable):

All


Actual behavior:

Attempt to upgrade/reinstall template results in template lacking root.img when yum command does not retrieve a package for installation (e.g. user --action results in "Nothing to do").

Steps to reproduce the behavior:

$ sudo qubes-dom0-update qubes-template-fedora-24 --action=upgrade

General notes:

This concerns the specific template reinstall code in qubes-dom0-update.

Condition after yum command should take return code and root.img presence into account simultaneously. This should result in the template's original files being restored under the scenario where a user specifies a reinstall-type action for a template but yum retrieves no package.

Will post tested patch shortly.


Related issues:

#2061
#2527

tasket added a commit to tasket/qubes-core-admin-linux that referenced this issue Jun 7, 2017

@tasket tasket referenced this issue in QubesOS/qubes-core-admin-linux Jun 7, 2017

Merged

Fix root.img handling bug #27

@andrewdavidwong andrewdavidwong added this to the Release 3.2 updates milestone Jun 8, 2017

@andrewdavidwong

This comment has been minimized.

Show comment
Hide comment
@andrewdavidwong

andrewdavidwong Jun 8, 2017

Member

I see that QubesOS/qubes-core-admin-linux#27 has already been merged, but I'll leave this open for builder tracking purposes.

CC @marmarek

Member

andrewdavidwong commented Jun 8, 2017

I see that QubesOS/qubes-core-admin-linux#27 has already been merged, but I'll leave this open for builder tracking purposes.

CC @marmarek

marmarek added a commit to QubesOS/qubes-core-admin-linux that referenced this issue Jun 13, 2017

Fix root.img handling bug
Per issue QubesOS/qubes-issues#2848

(cherry picked from commit 6d251d5)
Notes from origin:
    Fixes QubesOS/qubes-issues#2848
@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jun 13, 2017

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.2.15-1.fc23 has been pushed to the r3.2 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.2.15-1.fc23 has been pushed to the r3.2 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Jun 13, 2017

Closed

core-admin-linux v3.2.15 (r3.2) #79

@qubesos-bot qubesos-bot referenced this issue in QubesOS/updates-status Jul 5, 2017

Closed

core-admin-linux v4.0.1 (r4.0) #105

@qubesos-bot

This comment has been minimized.

Show comment
Hide comment
@qubesos-bot

qubesos-bot Jul 11, 2017

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.2.15-1.fc23 has been pushed to the r3.2 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.2.15-1.fc23 has been pushed to the r3.2 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment