qubes-dom0-update root.img handling bug

[tasket]

Qubes OS version (e.g., R3.2):

R3.1, R3.2

Affected TemplateVMs (e.g., fedora-23, if applicable):

All

---

Actual behavior:

Attempt to upgrade/reinstall template results in template lacking root.img when yum command does not retrieve a package for installation (e.g. user --action results in "Nothing to do").

Steps to reproduce the behavior:

$ sudo qubes-dom0-update qubes-template-fedora-24 --action=upgrade

General notes:

This concerns the specific template reinstall code in qubes-dom0-update.

Condition after yum command should take return code and root.img presence into account simultaneously. This should result in the template's original files being restored under the scenario where a user specifies a reinstall-type action for a template but yum retrieves no package.

Will post tested patch shortly.

---

Related issues:

#2061
#2527

[andrewdavidwong]

I see that QubesOS/qubes-core-admin-linux#27 has already been merged, but I'll leave this open for builder tracking purposes.

CC @marmarek

[qubesos-bot]

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.2.15-1.fc23 has been pushed to the r3.2 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

[qubesos-bot]

Automated announcement from builder-github

The package qubes-core-dom0-linux-3.2.15-1.fc23 has been pushed to the r3.2 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update