Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DVM Templates can't be deleted if they're their own default DVM Template #4224

Closed
strugee opened this issue Aug 18, 2018 · 25 comments · Fixed by QubesOS/qubes-core-admin-client#105

Comments

@strugee
Copy link
Contributor

strugee commented Aug 18, 2018

Qubes OS version:

R4.0

Affected component(s):

Qubes Manager(?)


Steps to reproduce the behavior:

  1. Install with the default settings, making sure to enable Whonix integration
  2. Try to delete whonix-ws-dvm
  3. Receive an error message saying to check system logs
  4. Observe that journalctl -xn says Cannot remove whonix-ws-dvm, used by whonix-ws-dvm.default_dispvm

Expected behavior:

VM DVM Template is removed without fuss as long as nothing else is using it.

Actual behavior:

Qubes refused to delete the DispVM DVM Template because it was its own default DispVM DVM Template.

@andrewdavidwong andrewdavidwong added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: core ux User experience labels Aug 18, 2018
@andrewdavidwong andrewdavidwong added this to the Release 4.0 updates milestone Aug 18, 2018
@andrewdavidwong
Copy link
Member

I think you might be missing the distinction between DVM Templates and DispVMs.

@RefinedSoftwareLLC
Copy link

RefinedSoftwareLLC commented Aug 21, 2018

With R4.0, security-testing. I was unable to delete a "-dvm" qube because its "Default DispVM" was set to itself. Since the delete command will also delete the offending qube (itself) this shouldn't prevent the deletion.

P.S. Error message said to look at system logs, but didn't say which qube (I assume Dom0), and it didn't say which log file (Dom0 has many files in the system log folder.)

@strugee
Copy link
Contributor Author

strugee commented Aug 22, 2018

@andrewdavidwong sorry for the delay! I definitely might be wrong about the terminology; I'm new to Qubes. I think the bug I was describing is still valid though.

@strugee
Copy link
Contributor Author

strugee commented Aug 22, 2018

@RefinedSoftwareLLC can you file a separate issue for the error message improvements? That would be a useful fix and probably pretty easy to do. You'd have to search for duplicates first.

@andrewdavidwong
Copy link
Member

I definitely might be wrong about the terminology; I'm new to Qubes. I think the bug I was describing is still valid though.

But it's important to get the terminology right, or else others won't understand what you're saying. Could you please update your issue with the correct terminology?

@strugee strugee changed the title DispVMs can't be deleted if they're their own default DispVM DVM Templates can't be deleted if they're their own default DVM Template Aug 24, 2018
@strugee
Copy link
Contributor Author

strugee commented Aug 24, 2018

@andrewdavidwong fixed

@andrewdavidwong
Copy link
Member

Thanks, but it still doesn't make sense to me to say that a DVM Template "is its own DVM Template." AFAIK, that's impossible, since only DispVMs (which cannot themselves be DVM Templates) have DVM Templates. But maybe that's the bug you're reporting.

@strugee
Copy link
Contributor Author

strugee commented Aug 25, 2018

I think you've misread the edit; I am talking about A DVM Template being set as its own default DVM Template. AFAIUI this is the template that gets used by default when e.g. "open in DispVM" menu items are used.

@andrewdavidwong
Copy link
Member

I think you've misread the edit; I am talking about A DVM Template being set as its own default DVM Template. AFAIUI this is the template that gets used by default when e.g. "open in DispVM" menu items are used.

Ah, I think I see what you mean now. Thanks for the clarification.

@RefinedSoftwareLLC
Copy link

RefinedSoftwareLLC commented Aug 30, 2018

Part of the confusion is coming from a typo in the Qube Manager. Both the origional post and my above post are quoting a setting from the Qube Manager called "Default DispVM".

Open this window: "Qube Manager" > Menu "Qube" > "Qube Settings" > Tab "Advanced"

  • Then please rename the setting "Default DispVM:" to "Default DVM Template:".

@strugee
Copy link
Contributor Author

strugee commented Aug 30, 2018

@RefinedSoftwareLLC can you file a separate issue for the error message improvements? That would be a useful fix and probably pretty easy to do. You'd have to search for duplicates first.

I didn't want this to drop off the radar so I went to file a new issue. While searching for duplicates I found #1300 but I'm not sure if it entirely covers the vague error messages being described above?

@andrewdavidwong
Copy link
Member

While searching for duplicates I found #1300 but I'm not sure if it entirely covers the vague error messages being described above?

I'd say it falls under #1300, but either way would be fine in this case.

@strugee
Copy link
Contributor Author

strugee commented Aug 31, 2018

In any case I filed QubesOS/qubes-core-admin#226 to fix the error message.

@qubesos-bot
Copy link

Automated announcement from builder-github

The package python2-qubesadmin-4.1.0-1.fc29 has been pushed to the r4.1 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-core-admin-client_4.1.0-1 has been pushed to the r4.1 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing stretch-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-admin-client has been pushed to the r4.1 testing repository for the CentOS centos7 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.1-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-core-admin-client_4.0.28-1+deb9u1 has been pushed to the r4.0 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-admin-client has been pushed to the r4.0 stable repository for the CentOS centos7 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package python2-qubesadmin-4.0.28-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment