Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permanent disposable USB VM keeps getting included in backups after repeatedly excluding it #4831

Closed
andrewdavidwong opened this issue Feb 18, 2019 · 2 comments
Closed

Permanent disposable USB VM keeps getting included in backups after repeatedly excluding it #4831

andrewdavidwong opened this issue Feb 18, 2019 · 2 comments
Labels
C: core r4.0-dom0-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Milestone
Release 4.0 updates

Comments

@andrewdavidwong
Copy link
Member

andrewdavidwong commented Feb 18, 2019 •
edited
Loading

Qubes OS version:

R4.0

Affected component(s):

Unknown

Steps to reproduce the behavior:

  1. Create a permanent disposable USB VM.
  2. Set it to autostart.
  3. As a workaround to qubesadmin.backup: Error attaching device pci:X to disposable-usb-vm: 'dict' object has no attribute 'attach' #4830, set the USB VM not to be included in backups, i.e., make qvm-prefs show: 
    include_in_backups - False

Expected behavior:

The USB VM is not included in backups.

Actual behavior:

Somehow, the USB VM randomly gets include_in_backups set back to True without the user doing it. The user has to keep unchecking that box in Qubes Manager or keep turning it off with qvm-prefs, but it keeps coming back by itself.

General notes:

Related issues:

#4830
@andrewdavidwong andrewdavidwong added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. C: core labels Feb 18, 2019
@andrewdavidwong andrewdavidwong added this to the Release 4.0 updates milestone Feb 18, 2019
@andrewdavidwong andrewdavidwong changed the title Disposable USB VM keeps getting included in backups after repeatedly excluding it Permanent disposable USB VM keeps getting included in backups after repeatedly excluding it Feb 18, 2019
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Feb 18, 2019
@marmarek
Use correct bool properties parsing by default
24c0c9d 
Boolean properties require specific setter to properly handle literal
"True" and "False" values. Previously it required all bool properties to
include 'setter=qubes.property.bool' in addition to 'type=bool'.
This fixes loading some boolean properties from qubes.xml. Specifically
at least include_in_backups on DispVM class lacked setter, which
resulted in property being reset to True automatically on qubesd
restart.

Fixes QubesOS/qubes-issues#4831
@marmarek marmarek mentioned this issue Feb 27, 2019
Merged
@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-core-dom0-4.0.41-1.fc25 has been pushed to the r4.0 testing repository for dom0.
To test this update, please install it with the following command:

sudo qubes-dom0-update --enablerepo=qubes-dom0-current-testing

Changes included in this update

This was referenced Mar 8, 2019
Closed
Closed
@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-core-dom0-4.0.41-1.fc25 has been pushed to the r4.0 stable repository for dom0.
To install this update, please use the standard update command:

sudo qubes-dom0-update

Or update dom0 via Qubes Manager.

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: core r4.0-dom0-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
Milestone
Release 4.0 updates
Development

No branches or pull requests
2 participants
@andrewdavidwong @qubesos-bot