-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misalignment of volatile LVs? #5151
Comments
Update: if 0 is not possible (I have read that LV should have a MBR block 0 partition table to prevent corruption of volume by poorly written tools), then probably something like 2048 would be better from an alignment perspective, even if it "wastes" space temporarily. Unless someone has more wisdom on this than I, of course. B Updated to list only the current linux standard of 1MB (block no. 2048 w/ 512B blocks) alignment. |
Slightly related: #4974 |
this seems actualy a bit silly. i did some rapid tests against the volatile of a vm on a raid1-of-two-ssds. dom0 says in fdisk-l on the /dev/mapper/blahbla-volatile: so no weird sector sizes or anything. aligining the swap to 1MB might really be the sanest option there. (and as long we are talking lvm-thin with no more than 1MB blocksize, it doesnt really even waste that one mb) |
Ha! I didn't even think of this. If we skip forward to the 1MB for the partition, then at most one cluster will be written before that mark (for the partition table), so unless the LVM host VG is rather large, most of the 1MB will be unallocated anyway. |
(cherry picked from commit ecc0b70) Notes from origin: Fixes QubesOS/qubes-issues#5151
Automated announcement from builder-github The package
|
Automated announcement from builder-github The package
|
Automated announcement from builder-github The package
|
Automated announcement from builder-github The package
|
Automated announcement from builder-github The package
|
Automated announcement from builder-github The package
|
Automated announcement from builder-github The package
|
Automated announcement from builder-github The package
Or update dom0 via Qubes Manager. |
Automated announcement from builder-github The package
|
Qubes OS version
R4.01 (current-testing)
Affected component(s) or functionality
Volatile LVs
Brief summary
Just by happenstance, while prepping some devices for new installs, I happened to type fdisk -l into the wrong window, and looked at the output of fdisk -l in dom0, which flagged the alignment issues in red.
To Reproduce
Expected behavior
Start sector/block should be 0, not 1.
Actual behavior
Start is 1
Additional context
This is non-optimal from a SSD perfomance and device lifetime perspective, though I'm not sure how that interacts with the LVs being hosted on a thin-pool with 64KB clusters.
B
The text was updated successfully, but these errors were encountered: