Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Korean characters not displayed in web browser #5937

Closed
mfc opened this issue Jul 7, 2020 · 9 comments · Fixed by QubesOS/qubes-builder-rpm#136
Closed

Korean characters not displayed in web browser #5937

mfc opened this issue Jul 7, 2020 · 9 comments · Fixed by QubesOS/qubes-builder-rpm#136
Labels
affects-4.1 This issue affects Qubes OS 4.1. affects-4.2 This issue affects Qubes OS 4.2. C: templates diagnosed Technical diagnosis has been performed (see issue comments). localization This issue concerns translating things into different languages or adapting them to other regions. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
Funder-supported improvements to Usab...

Comments

@mfc
Copy link
Member

mfc commented Jul 7, 2020

Qubes OS version
R4.0

Brief summary
FF, Chromium in Debian 10, FF in Fedora 32 all can display other non-latin languages like Chinese, Arabic, Japanese, etc. For some reason Korean isn't displayed.

To Reproduce
Steps to reproduce the behavior:
_1. Go to https://ko.wikipedia.org
_2. See all the unicode boxes

to compare, here is Japanese wikipedia homepage and Chinese wikipedia homepage.

Expected behavior
Korean characters are also displayed.

Actual behavior
Korean characters are not displayed.

Relevant documentation you've consulted
https://www.qubes-os.org/doc/language-localization/

Related, non-duplicate issues
#1059
#5914
@mfc mfc added T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. localization This issue concerns translating things into different languages or adapting them to other regions. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Jul 7, 2020
@marmarek
Copy link
Member

marmarek commented Jul 7, 2020

Looks like some font package not installed by default. It works just fine on my fedora-32 customized template and also in stock fedora-30 template, but not on stock fedora-32 template.

@andrewdavidwong andrewdavidwong added this to the Release 4.0 updates milestone Jul 7, 2020
@iamahuman
Copy link

iamahuman commented Jul 8, 2020 •
edited
Loading

For anyone affected by the problem, try sudo dnf install naver-nanum-gothic-fonts in TemplateVM.

For a comprehensive list of other Korean fonts, do sudo dnf search --all Korean | grep -i font. If this is a regression from Fedora 30, perhaps we can do a diff on the installed packages filtering by above.

That said, it would be nice if we used the existing GNOME software machinery to tell the user which additional fonts shall be installed (so that we do not bloat the template), or install Noto Sans or Droid Sans Fallback CJK fonts by default as a catch-all fallback.

@zpc0
Copy link

zpc0 commented Jul 20, 2020

This problem seems to be caused by the updated Droid Sans fonts.

google-droid-fonts-20200215-3.fc32 uses DroidSansFallbackFull.ttf as the fallback fonts, but Hangul has been removed from DroidSansFallbackFull.ttf.
Therefore, a system that doesn't have other Hangul fonts cannot display Hangul characters correctly.

I think google-noto-sans-cjk-ttc-fonts is a better choice. It provides more updated and complete fonts to CJK users.

@andrewdavidwong andrewdavidwong added the diagnosed Technical diagnosis has been performed (see issue comments). label Jul 22, 2020
@zpc0
Copy link

zpc0 commented Nov 14, 2020 •
edited
Loading

I'm considering using @fonts meta package to fix this issue. Maintaining fonts list is a hard task because it requires knowledge of many languages, so I think @fonts is a simple solution.

@marmarek @fepitre
Is it ok to add @fonts to packages_fc.list?
If yes, I will send a patch.

@iamahuman
Copy link

@zpc0 I suppose https://github.com/mozilla/gecko-dev/blob/544653167f12b44d6358cc3a60a6151caca3c85d/gfx/thebes/StandardFonts-linux.inc would be a good reference

@zpc0
Copy link

zpc0 commented Nov 18, 2020

@zpc0 I suppose https://github.com/mozilla/gecko-dev/blob/544653167f12b44d6358cc3a60a6151caca3c85d/gfx/thebes/StandardFonts-linux.inc would be a good reference

Thank you. I checked the difference between StandardFonts-linux.inc and qubes fedora-32 template.
The following fonts are missing in the fedora-32 template.

"Abyssinica SIL" "Caladea" "Carlito" "Comfortaa" "Jomolhari" "Khmer OS" "Liberation" "Lohit Assamese" "Lohit Bengali" "Lohit Devanagari" "Lohit Gujarati" "Lohit Kannada" "Lohit Odia" "Lohit Tamil" "Lohit Telugu" "Meera" "Mingzat" "Montserrat" "Noto Color Emoji" "Noto Sans CJK" "Noto Sans Gurmukhi" "Noto Sans Mono CJK" "Noto Sans Sinhala" "Nuosu SIL" "Padauk" "PakType Naskh Basic" "PT Sans" "STIX" "Symbola" "Waree"

@mfc
Copy link
Member Author

mfc commented Feb 20, 2022

still a problem in R4.1 with default templates (debian 11, fedora 34), but not an issue with whonix-16-ws.

would be good to have decent (and consistent) font representation in default templates, for instance by relying on externally maintained font meta-packages mentioned earlier in thread. looping in @fepitre so they're aware in case they have thoughts.

@andrewdavidwong andrewdavidwong added eol-4.0 Closed since Qubes 4.0 has been EOL for over one year and removed eol-4.0 Closed since Qubes 4.0 has been EOL for over one year labels Aug 5, 2023
@andrewdavidwong andrewdavidwong added the affects-4.1 This issue affects Qubes OS 4.1. label Aug 8, 2023
@andrewdavidwong andrewdavidwong removed this from the Release 4.1 updates milestone Aug 13, 2023
@UndeadDevel
Copy link

Still a problem on 4.2 with debian-12-xfce (haven't checked the other templates).

@andrewdavidwong andrewdavidwong added affects-4.2 This issue affects Qubes OS 4.2. C: templates and removed C: Fedora labels Dec 28, 2023
@mfc
Copy link
Member Author

mfc commented Mar 15, 2024

also a problem with fedora-38-xfce on R4.2, except for all CJK languages not just korean.

installing google-noto-sans-cjk and google-noto-sans-cjk-ttc-font solves the problem, inspired from: https://bugzilla.redhat.com/show_bug.cgi?id=2188765#c0 and https://discussion.fedoraproject.org/t/chinese-font-issue-on-fedora-silverblue-39/100015/9

would be really amazing to ensure CJK fonts are included in template releases, ideally through font meta-packages.

zpc0 added a commit to zpc0/qubes-builder-rpm that referenced this issue Mar 18, 2024
@zpc0
use default-fonts meta-packages
c4888f8 
Fedora 39 introduces default-fonts meta-package.
This package pulls minimal fonts packages for all supported
languages. Without this, some characters (Korean etc,) are
not displayed correctly.

Size increase is about 150MiB.

QubesOS/qubes-issues#5937
@zpc0 zpc0 mentioned this issue Mar 18, 2024
Closed
@marmarek marmarek mentioned this issue Jun 12, 2024
Merged
@andrewdavidwong andrewdavidwong added the pr submitted A pull request has been submitted for this issue. label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-4.1 This issue affects Qubes OS 4.1. affects-4.2 This issue affects Qubes OS 4.2. C: templates diagnosed Technical diagnosis has been performed (see issue comments). localization This issue concerns translating things into different languages or adapting them to other regions. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
Funder-supported improvements to Usab...
Localization
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use default fonts group instead of selected fonts marmarek/qubes-builder-rpm
6 participants
@marmarek @mfc @andrewdavidwong @iamahuman @UndeadDevel @zpc0