Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unified grub.cfg location #7985

Closed
marmarek opened this issue Jan 13, 2023 · 2 comments
Closed

Use unified grub.cfg location #7985

marmarek opened this issue Jan 13, 2023 · 2 comments
Labels
C: core C: mgmt C: Xen P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. release notes This issue should be mentioned in the release notes. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.
Milestone

Comments

@marmarek
Copy link
Member

How to file a helpful issue

The problem you're addressing (if any)

Currently grub.cfg is in different place depending on EFI or legacy boot. This makes various documentation and scripts needing extra cases for boot mode.

The solution you'd like

Follow https://fedoraproject.org/wiki/Changes/UnifyGrubConfig

The value to a user, and who that user might be

Easier documentation and boot parameters handling. For example regenerating grub config is always grub2-mkconfig -o /boot/grub2/grub.cfg - regardless of the boot mode.

@marmarek marmarek added T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality. release notes This issue should be mentioned in the release notes. P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Jan 13, 2023
@marmarek marmarek added this to the Release 4.2 milestone Jan 13, 2023
@marmarek
Copy link
Member Author

The change in grub itself is already implemented (ported patch from Fedora). This issue is for tracking purposes for updating other parts, and for release notes.

marmarek added a commit to marmarek/qubes-core-admin-linux that referenced this issue Jan 13, 2023
Grub2 in R4.2 is made to include grub.cfg from primary /boot partition,
even on EFI systems - so it always lives in the same place. Do not not
override the config stub.

QubesOS/qubes-issues#7985
marmarek added a commit to marmarek/qubes-vmm-xen that referenced this issue Jan 13, 2023
Grub2 in R4.2 is made to include grub.cfg from primary /boot partition,
even on EFI systems - so it always lives in the same place. Do not not
override the config stub.

QubesOS/qubes-issues#7985
marmarek added a commit to marmarek/qubes-mgmt-salt-dom0-virtual-machines that referenced this issue Jan 13, 2023
Grub2 in R4.2 is made to include grub.cfg from primary /boot partition,
even on EFI systems - so it always lives in the same place. Do not not
override the config stub.

QubesOS/qubes-issues#7985
marmarek added a commit to marmarek/qubes-mgmt-salt-dom0-virtual-machines that referenced this issue Feb 2, 2023
Now /boot/efi/EFI/qubes/grub.cfg sources /boot/grub2/grub.cfg, so the
actual config always is in /boot/grub2/grub.cfg, regardless of the boot
mode.

QubesOS/qubes-issues#7985
@marmarek
Copy link
Member Author

It seems all relevant places are updated already. The R4.1->R4.2 upgrade path is tracked separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: core C: mgmt C: Xen P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. release notes This issue should be mentioned in the release notes. T: enhancement Type: enhancement. A new feature that does not yet exist or improvement of existing functionality.
Projects
None yet
Development

No branches or pull requests

2 participants