Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox does not start on 4.2-rc3 after upgrading template #8571

Closed
feskehau opened this issue Oct 6, 2023 · 17 comments · Fixed by QubesOS/qubes-core-agent-linux#464
Closed
Labels
affects-4.1 This issue affects Qubes OS 4.1. affects-4.2 This issue affects Qubes OS 4.2. C: core C: Fedora diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. r4.1-bookworm-stable r4.1-bullseye-stable r4.1-buster-stable r4.1-fc37-stable r4.1-fc38-stable r4.2-vm-bookworm-stable r4.2-vm-bullseye-stable r4.2-vm-centos-stream8-stable r4.2-vm-fc37-stable r4.2-vm-fc38-stable r4.2-vm-fc39-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Milestone

Comments

@feskehau
Copy link

feskehau commented Oct 6, 2023

Qubes OS release

4.2-rc3

Brief summary

As of October 6th:
Firefox on Fedora-38-xfce does not start when selecting from app menu, works if started directly in VM terminal with command $ firefox. Noticed earlier today, had to reinstall to verify.

Suspect its the dbus or .desktop change:
https://src.fedoraproject.org/rpms/firefox/c/b85953896b4c0099084baa03c64ecd4aeb52d0c9?branch=rawhide

1121 1121 | %changelog
1122 | +             * Fri Oct 06 2023 Alessandro Astone <ales.astone@gmail.com> - 118.0.1-7
1123 | +             - Don't include -x11 and -wayland desktop files in the main package (rhbz#2242523)
1124 | +
1122 1125 | * Fri Oct 6 2023 Martin Stransky <stransky@redhat.com>- 118.0.1-6
1123 1126 | - Removed DBusActivatable flag from desktop file as it crashes KDE (rhbz#2242454).

Invalid bus name firefox:

[user@dom0 ~]$ sudo qvm-run -q -a -p --service -- personal qubes.StartApp+firefox
Traceback (most recent call last):
  File "/etc/qubes-rpc/qubes.StartApp", line 39, in <module>
    main(sys.argv)
  File "/etc/qubes-rpc/qubes.StartApp", line 33, in main
    launch(os.path.join(raw_volume, f))
  File "/usr/lib/python3.11/site-packages/qubesagent/xdg.py", line 106, in launch
    proxy = bus.get_object(service_id, object_path)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.11/site-packages/dbus/bus.py", line 237, in get_object
    return self.ProxyObjectClass(self, bus_name, object_path,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.11/site-packages/dbus/proxies.py", line 241, in __init__
    _dbus_bindings.validate_bus_name(bus_name)
ValueError: Invalid bus name 'firefox': must contain '.'

Steps to reproduce

  1. Install Qubes 4.2-rc3
  2. Upgrade dom0 and all templates
  3. Try starting firefox using app menu
  4. Firefox wont work

Expected behavior

Expected firefox to start.

Actual behavior

VM boots, firefox does not start.
If vm already booted, firefox does not start.

@feskehau feskehau added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Oct 6, 2023
@marmarek
Copy link
Member

marmarek commented Oct 7, 2023

In fact the changelog entries you cited are about fix for this issue. Unfortunately, the version 118.0.1-6 or 118.0.1-7 isn't in the repository yet. It's still building: https://koji.fedoraproject.org/koji/buildinfo?buildID=2302654

Fedora bug report: https://bugzilla.redhat.com/show_bug.cgi?id=2242454
Workaround in Qubes: QubesOS/qubes-core-agent-linux#463

@andrewdavidwong andrewdavidwong added C: Fedora C: core diagnosed Technical diagnosis has been performed (see issue comments). waiting for upstream This issue is waiting for something from an upstream project to arrive in Qubes. Remove when closed. affects-4.2 This issue affects Qubes OS 4.2. labels Oct 7, 2023
@GWeck
Copy link

GWeck commented Oct 7, 2023

Thias also happens with qubes based on Fedora 38 under Qubes R4.1.2. Qubes based on Fedora 37 still start Firefox correctly via the menu.

@rustybird
Copy link

Repost from the forum:

To fix the launcher problem right now, people can remove the line DBusActivatable=true in /usr/share/applications/firefox.desktop on their Fedora TemplateVM.

marmarek added a commit to QubesOS/qubes-core-agent-linux that referenced this issue Oct 8, 2023
Recent Fedora broke firefox.desktop, by setting DBusActivatable=true,
while having invalid dbus name.
Fallback to a classic launch if loading dbus object fails.

Workaround for https://bugzilla.redhat.com/show_bug.cgi?id=2242454

Fixes QubesOS/qubes-issues#8571
Co-developed-with: Tobias Neitzel <tobias.neitzel@code-white.com>

(cherry picked from commit 3c2c33e)
marmarek added a commit to QubesOS/qubes-core-agent-linux that referenced this issue Oct 8, 2023
Recent Fedora broke firefox.desktop, by setting DBusActivatable=true,
while having invalid dbus name.
Fallback to a classic launch if loading dbus object fails.

Workaround for https://bugzilla.redhat.com/show_bug.cgi?id=2242454

Fixes QubesOS/qubes-issues#8571
Co-developed-with: Tobias Neitzel <tobias.neitzel@code-white.com>

(cherry picked from commit 3c2c33e)
@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bullseye-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.2 testing repository for the CentOS centos-stream8 template.
To test this update, please install it with the following command:

sudo yum update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing bookworm-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-core-agent_4.1.46-1 has been pushed to the r4.1 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing buster-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@andrewdavidwong andrewdavidwong added the affects-4.1 This issue affects Qubes OS 4.1. label Oct 8, 2023
@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.2 stable repository for the CentOS centos-stream8 template.
To install this update, please use the standard update command:

sudo yum update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.2 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.2 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package qubes-core-agent_4.1.46-1+deb10u1 has been pushed to the r4.1 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.1 This issue affects Qubes OS 4.1. affects-4.2 This issue affects Qubes OS 4.2. C: core C: Fedora diagnosed Technical diagnosis has been performed (see issue comments). P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. pr submitted A pull request has been submitted for this issue. r4.1-bookworm-stable r4.1-bullseye-stable r4.1-buster-stable r4.1-fc37-stable r4.1-fc38-stable r4.2-vm-bookworm-stable r4.2-vm-bullseye-stable r4.2-vm-centos-stream8-stable r4.2-vm-fc37-stable r4.2-vm-fc38-stable r4.2-vm-fc39-stable T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
6 participants