Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qubes Updater considers in-place upgraded qubes to be "no longer supported" #8725

Closed
Minimalist73 opened this issue Nov 23, 2023 · 30 comments · Fixed by QubesOS/qubes-doc#1371, QubesOS/qubes-core-agent-linux#481 or QubesOS/qubes-core-admin#578
Assignees
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: doc C: manager/widget C: updates diagnosed Technical diagnosis has been performed (see issue comments). P: critical Priority: critical. Between "major" and "blocker" in severity. pr submitted A pull request has been submitted for this issue. r4.2-host-stable r4.2-vm-bookworm-stable r4.2-vm-fc37-stable r4.2-vm-fc38-stable r4.2-vm-fc39-stable r4.2-vm-fc40-stable r4.2-vm-trixie-stable r4.3-vm-bookworm-cur-test r4.3-vm-fc39-cur-test r4.3-vm-fc40-cur-test r4.3-vm-trixie-cur-test T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.

Comments

@Minimalist73
Copy link

Qubes OS release

4.2-rc4

Brief summary

The new Qubes Updater introduced a new way to detect if a template or standalone qube is no longer supported.
It works, but shows false positives for users who use the in-place upgrade method for their qubes.
The "template-name" option in qvm-features retains its old value and Qubes Updater uses it to check if the system is EOL.

Steps to reproduce

Not really reproducible by itself, since it only happens to users who upgrade their templates/standalone qubes in-place.
Can be artificially reproduced by changing the template-name value to an old template version:

  • qvm-features fedora-38-xxx template-name fedora-35

Expected behavior

No "no longer supported" message should appear in Qubes Updater qui if the qube runs a supported release.

Actual behavior

Say that some of my qubes are no longer supported (reported as "obsolete" in Qubes Updater itself) when they are fully upgraded to fedora-38.
Running qvm-features on one of the affected template reports the following:

template-name                               fedora-35
template-epoch                              0
template-version                            4.0.6
template-release                            202111131804
template-reponame                           qubes-templates-itl-testing
template-buildtime                          2021-11-13 19:14:50
template-installtime                        2021-12-07 18:11:25
template-license                            GPL
template-url                                http://www.qubes-os.org
template-summary                            Qubes template for fedora-35
template-description                        Qubes template for fedora-35
@Minimalist73 Minimalist73 added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Nov 23, 2023
@ben-grande
Copy link

Note that these features are set on package installation, not when modifying the qube from inside.

If this is a bug, it is in the documentation, maybe it should tell you to update the template-name, template-summary and template-description feature? I don't know if the other features should be changed.

But then it would also need to recommend you to set a new feature template-original-name or something like it, so you can know from which version you started doing in-place upgrades. This way the Updater could work with in-place upgrades.

@andrewdavidwong andrewdavidwong added C: manager/widget C: doc needs diagnosis Requires technical diagnosis from developer. Replace with "diagnosed" or remove if otherwise closed. C: updates affects-4.2 This issue affects Qubes OS 4.2. labels Nov 24, 2023
@andrewdavidwong
Copy link
Member

@andrewdavidwong andrewdavidwong added P: major Priority: major. Between "default" and "critical" in severity. and removed P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. labels Dec 3, 2023
@kennethrrosen
Copy link

Note that these features are set on package installation, not when modifying the qube from inside.

If this is a bug, it is in the documentation, maybe it should tell you to update the template-name, template-summary and template-description feature? I don't know if the other features should be changed.

But then it would also need to recommend you to set a new feature template-original-name or something like it, so you can know from which version you started doing in-place upgrades. This way the Updater could work with in-place upgrades.

Confirming: Running qvm-features fedora-39 template-name fedora-39 or the like resolves the issues.

@avaaum
Copy link

avaaum commented Dec 10, 2023

does not work for me. the issue still persists.

@runephilosof-abtion
Copy link

does not work for me. the issue still persists.

I had to reboot after changing the template names to have the updater notice it.

@runephilosof-abtion
Copy link

According to https://forum.qubes-os.org/t/fedora-template-no-longer-supported-4-2-0-rc5/22506/4, it should be enough to restart the widget. But I don't know how to do that.

@andrewdavidwong andrewdavidwong added P: critical Priority: critical. Between "major" and "blocker" in severity. and removed P: major Priority: major. Between "default" and "critical" in severity. labels Jan 10, 2024
@andrewdavidwong
Copy link
Member

@sjvudp
Copy link

sjvudp commented Jan 19, 2024

As I'm affected, too, I can tell:
qvm-features fedora-38 reports (among many other lines):

template-name                               fedora-36
template-epoch                              0
template-version                            4.0.6
template-release                            202205270243
template-reponame                           @commandline
template-buildtime                          2022-05-27 03:11:26
template-installtime                        2022-09-02 22:50:42
template-license                            GPL
template-url                                http://www.qubes-os.org
template-summary                            Qubes template for fedora-36
template-description                        Qubes template for fedora-36
updates-available                           
last-updates-check                          2024-01-19 22:21:28

So my guess is that one step in the template upgrade guide is missing ;-)

@andrewdavidwong andrewdavidwong pinned this issue Jan 20, 2024
marmarek added a commit to marmarek/qubes-core-agent-linux that referenced this issue Jan 28, 2024
Send distribution, version and EOL data to dom0.

Fixes QubesOS/qubes-issues#8725
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Jan 28, 2024
Save distribution, version and EOL date in features.

Fixes QubesOS/qubes-issues#8725
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Jan 28, 2024
Save distribution, version and EOL date in features.

Fixes QubesOS/qubes-issues#8725
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Jan 28, 2024
Save distribution, version and EOL date in features.

Fixes QubesOS/qubes-issues#8725
marmarek added a commit to marmarek/qubes-core-admin that referenced this issue Jan 29, 2024
Save distribution, version and EOL date in features.

Fixes QubesOS/qubes-issues#8725
@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.3 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing trixie-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.3 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.3-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.2 testing repository for the Debian template.
To test this update, first enable the testing repository in /etc/apt/sources.list.d/qubes-*.list by uncommenting the line containing trixie-testing (or appropriate equivalent for your template version), then use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 testing repository for the Fedora template.
To test this update, please install it with the following command:

sudo dnf update --enablerepo=qubes-vm-r4.2-current-testing

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.2 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The package core-agent-linux has been pushed to the r4.2 stable repository for the Debian template.
To install this update, please use the standard update command:

sudo apt-get update && sudo apt-get dist-upgrade

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

@qubesos-bot
Copy link

Automated announcement from builder-github

The component core-agent-linux (including package core-agent-linux) has been pushed to the r4.2 stable repository for the Fedora template.
To install this update, please use the standard update command:

sudo dnf update

Changes included in this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-4.2 This issue affects Qubes OS 4.2. C: doc C: manager/widget C: updates diagnosed Technical diagnosis has been performed (see issue comments). P: critical Priority: critical. Between "major" and "blocker" in severity. pr submitted A pull request has been submitted for this issue. r4.2-host-stable r4.2-vm-bookworm-stable r4.2-vm-fc37-stable r4.2-vm-fc38-stable r4.2-vm-fc39-stable r4.2-vm-fc40-stable r4.2-vm-trixie-stable r4.3-vm-bookworm-cur-test r4.3-vm-fc39-cur-test r4.3-vm-fc40-cur-test r4.3-vm-trixie-cur-test T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists.
Projects
None yet
10 participants