-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow automatic configuration of Host based routing #28
Comments
hi Ryan,
Thanks for your support!
|
Are there docs for the auto configuration? I couldn't seem to find them in the README |
Take a look the release log under v0.2.1
|
+1 for this feature |
@rthomas Did you look at the current release? Does the default ACL rule that use application id as path solve most of the automation issue? Thanks |
Hi @activars - I did take a look at the docs, and whilst this does automate it, it is not quite what I need. This sits on the edge, and I need to be able to route requests via the Host header - not by the path. I'm sure we could come up with a way to determine the host from the application name in marathon, but I think it would be a lot cleaner to wait for marathon to implement the tagging and do it based on a tag. I also have some additional concerns about the I'm happy to implement this feature once we have the tagging in marathon. |
Defining BAMBOO_TCP_PORT in the Marathon task definition, e.g. { "id": "test", "cmd": "python -m SimpleHTTPServer $PORT0", "cpus": 0.1, "mem": 90, "ports": [0], "instances": 1 "env": { "BAMBOO_TCP_PORT": "1080" } } leads to listen ::test-cluster-tcp :1081 mode tcp option tcplog balance roundrobin server ::test-192.168.2.2-31001 192.168.2.2:31001 in the haproxy configuration. Fixes QubitProducts#28.
+1 thanks! |
@cmoro-deusto |
That´s great. Thanks a lot @activars |
@rthomas congrats, just noticed you are now working for Google. :) |
@activars labels might be a better choice since they do not pollute the process environment ? |
The environment variables feature pre-dates marathon and Mesos' label feature, but I agree it's probably a cleaner solution. Haven't upgraded our mesos stacks to 0.22.x yet or i'd have submitted a PR myself. |
Labels just landed if anyone is still waiting on them. |
I'm having trouble adding automatic acl creation of host based routing via this:
The problem is that I believe the else condition is never met and therefore the default proxy rule isn't getting created. We pass in "SUBDOMAIN" as a ENV in our Marathon Task Definitions. Am I doing something wrong there? I guess I don't understand what the if block is doing. |
you can check the data structure bamboo is going to use to template by looking at 0:8080/api/state . I've had older marathons give odd responses which sometimes mess up that structure (see #136). |
@dwstevens you might want to create a different issue. Do you mind first check if |
Actually, it seems to be working fine. I chased my tail for several hours yesterday. The Bamboo UI wasn't automatically updating with the ACL rules. I just manually refreshed and all the automatically created ACLs are correctly listed. I spent way too much time yesterday learning about Go templates! Thanks for the help. |
+1 for this feature |
This is dependent on this issue in marathon: mesosphere/marathon#599
It would be great if I could configure Bamboo to automatically configure apps to hostnames via specifying metadata to Marathon.
For example, if I could specify a tag in Marathon of
bamboo.hostname: my-app.example.com
and have bamboo automatically configure that application when it sees it.This would allow us to automatically configure and provision the load balancing for services based off of metadata for the application itself, rather than making a separate api call to provision load balancing.
The text was updated successfully, but these errors were encountered: