Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating entries using PUT #81

Closed
c089 opened this issue Feb 17, 2015 · 7 comments
Closed

Allow creating entries using PUT #81

c089 opened this issue Feb 17, 2015 · 7 comments

Comments

@c089
Copy link

c089 commented Feb 17, 2015

Currently, to get a "create or update" behaviour, clients have to implement it themselves, because POSTing with an existing id will fail, as will putting with a non-existing id. It would be convenient if PUT could be used for creating new configurations too.

@j1n6
Copy link
Contributor

j1n6 commented Mar 30, 2015

I'm working on this.

@j1n6
Copy link
Contributor

j1n6 commented Mar 31, 2015

how about allowing creating and updating entry using POST?

@c089
Copy link
Author

c089 commented Apr 1, 2015

Why would you want to use POST instead of PUT for this?

@j1n6
Copy link
Contributor

j1n6 commented Apr 1, 2015

I checked with Marathon guys, they keep creating new app feature in PUT (used to work with POST, but they deprecated in 0.8.1). I will keep it consistent with Marathon allowing PUT to create new record. Ignore my previous comment. :)

A working solution should available by end the week.

@c089
Copy link
Author

c089 commented Apr 1, 2015

👍 thanks for your work

@j1n6
Copy link
Contributor

j1n6 commented Apr 3, 2015

I'm also improving API URL encoding #58 issue together with this.
So you should be able to PUT /api/services/{marathon-app-id} without escaping the Marathon App ID.

It turns out the internal webserver goji changes HTTP behaviour when URL has double '//' by forcing 301 redirect and losing HTTP body (I don't like this...). I'm considering moving to other webservers, hopefully it's not too much work involved.

@j1n6
Copy link
Contributor

j1n6 commented Apr 18, 2015

Closed by #109
Bamboo's API URI requirement has changed, you don't need to encode Marathon AppId Anymore.

@j1n6 j1n6 closed this as completed Apr 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants