Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: API Refactoring #109

Merged
merged 6 commits into from
Apr 18, 2015
Merged

WIP: API Refactoring #109

merged 6 commits into from
Apr 18, 2015

Conversation

j1n6
Copy link
Contributor

@j1n6 j1n6 commented Apr 6, 2015

This is a WIP branch that aims to improve:

  • API does not require to escape application id
    • CREATE
    • PUT /api/services/{appId} should be able to create missing app configuration
    • DELETE
  • Fix UI
  • Ensure the PORT configuration has backwards compatibility due to webserver changes
    • check commandline flag
    • check Dockerfile
  • Update documentation
  • Rebase & Squash
  • Prepare release and write down api breakage

Note:
I have to remove goji as it's using golang's default http. It's too pure as it will redirect http://host/a//b to http://host/a/b, which results to loosing http body on PUT or POST request.

…r better that doesn't redirect unclean url from // to / (default go server behaviour)
- PUT allow creating missing app configuration
- REST API URI for Marathon ID does not require encoding
- Fix UI related API changes
- Fix Napa angular reference
@j1n6 j1n6 force-pushed the feature_support_put_create branch from b1b3ad0 to 4c95738 Compare April 18, 2015 21:11
j1n6 pushed a commit that referenced this pull request Apr 18, 2015
@j1n6 j1n6 merged commit 7a28436 into master Apr 18, 2015
@j1n6 j1n6 deleted the feature_support_put_create branch April 18, 2015 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant