Now using golang:1.6.2 as a base for docker images #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Sent from my iPhone
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there.
As stated in #200 , Go 1.6 may fix some issues. This PR changes the base image in Dockerfiles to switch to golang:1.6.2.
Please note that
golangimage is based onjessie-scm, so your existing Dockerfiles were mainly compatible with it.GOPATHis/goongolangimage, so i had to change this, and i also removed some (apparently ?) unused ppa repositories which would have not been compatible withjessie-scmanyway.Disclaimer : i tested
Dockerfileon our production cluster, works great. But i wasn't able to testDockerfile-deb. Only a few minor changes, so i assume it won't break anything, but i would feel it safer if someone who uses it everyday could confirm that.Thanks in adv. !