Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not preappend app ids with :: so that we can do routing based on the ... #59

Closed
wants to merge 1 commit into from

Conversation

thereforsunrise
Copy link

...app id as a host header

We would like to do routing based on the application id as a host header like so:

acl devint-widgetshop-api-aclrule hdr_beg(host) -m beg -i devint-widgetshop-api

To do this it would be great if the escaped app id was not preappended with :: .

I thought about adding another field to the struct but I couldn't think of a good reason why it is preappended with :: in the first place?

Thanks!

@j1n6
Copy link
Contributor

j1n6 commented Nov 13, 2014

This is related to #27. Ideally, I would like to take escaped app id out of the code base.

@j1n6
Copy link
Contributor

j1n6 commented Nov 13, 2014

So that generic regex function provided in template will allow you to customize the routing rule.

@j1n6
Copy link
Contributor

j1n6 commented Nov 13, 2014

Hey @zaargy, thanks for this PR. I'm aware of what you need, however the problem needs to be solved with the consideration of many other issues. I have to close this PR, but the regex function should be coming soon. I'm also accepting PR if you have a solution around it.

Thanks again.

@j1n6 j1n6 closed this Nov 13, 2014
@thereforsunrise
Copy link
Author

Thanks. I missed the regex function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants