Use promises instead of generators #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @KidkArolis to be a potential reviewer |
|
I find this hard to believe.. last time there was an issue with a missing try/catch in shelly? |
|
Try it out for yourself. Run 'fusion logs shelly', turn your WiFi off then
try loading the app. Now install this branch and do it again. Shelly is
able to catch it with this branch, and can't without it.
…On 1 Dec 2016 21:23, "Karolis Narkevicius" ***@***.***> wrote:
I find this hard to believe.. last time there was an issue with a missing
try/catch in shelly?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAl7CyVa2r27xv5xChkFQOSY3DIJ-pLWks5rDzrngaJpZM4LB2Df>
.
|
|
A load more of the lahore team are starting to get setup with shelly and are running into issues caused by this. @KidkArolis you ok for me to merge and release? |
|
Yes. |
|
Ta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@KidkArolis i don't know why this fixes it (i.e. i dont know what is wrong with the generator setup) but it does. Without each of these changes, shelly is unable to catch exceptions being thrown out of s3fs/aws-sdk; they end up getting emitted as unhandled rejections.
This is one of the things stopping us having better DX with shelly when developing both new apps that have never been released and when working offline.