Remove es6-promise dependency #88
Conversation
…ion to be defined as an option, defaulting to the global Promise
| @@ -36,10 +36,15 @@ Cherrytree.prototype.initialize = function (options) { | |||
| this.middleware = [] | |||
| this.options = _.extend({ | |||
| interceptLinks: true, | |||
| logError: true | |||
| logError: true, | |||
| Promise: window.Promise | |||
There was a problem hiding this comment.
need to do smth like typeof window === 'undefined' ? global.Promise : window.Promise to continue supporting node env.
There was a problem hiding this comment.
Specifically the node env support is just during webpack right? Then global.Promise should be fine. Also the actual webpack command should run in CI to catch this :)
|
Will try to sort out those travis builds a bit later. |
There's nothing to sort out unfortunately. Travis does not export secure env vars on pull requests for security reasons, so PR builds will always fail. |
|
I added my own saucelabs credentials on my fork and you can see the build passing |
| @@ -36,10 +36,13 @@ Cherrytree.prototype.initialize = function (options) { | |||
| this.middleware = [] | |||
| this.options = _.extend({ | |||
| interceptLinks: true, | |||
| logError: true | |||
| logError: true, | |||
| Promise: global.Promise | |||
There was a problem hiding this comment.
neat, I didn't realise this would work in all envs (browser and node) with the help of webpack
Remove es6-promise dependency
|
Cool thanks! Didn't know about |
A promise implementation must be specified as an option now if no global Promise implementation exists.