Add minimum chunk size requirement

QubitProducts · Mar 31, 2016 · f86cdf6 · f86cdf6
1 parent 230f265
commit f86cdf6
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/src/Upload.js b/src/Upload.js
@@ -14,12 +14,15 @@ import {
 } from './errors'
 import * as errors from './errors'
 
+const MIN_CHUNK_SIZE = 262144
+const DEFAULT_CHUNK_SIZE = 29999872 // 30MB (to nearest 256)
+
 export default class Upload {
   static errors = errors;
 
-  constructor (args) {
+  constructor (args, allowSmallChunks) {
     var opts = {
-      chunkSize: 29999872, // 30MB (to nearest 256)
+      chunkSize: DEFAULT_CHUNK_SIZE,
       storage: window.localStorage,
       contentType: 'text/plain',
       onChunkUpload: () => {},
@@ -29,7 +32,7 @@ export default class Upload {
       ...args
     }
 
-    if (opts.chunkSize % 256 !== 0) {
+    if (opts.chunkSize % 256 !== 0 || (opts.chunkSize < MIN_CHUNK_SIZE && !allowSmallChunks) {
       throw new InvalidChunkSizeError(opts.chunkSize)
     }
 

diff --git a/src/errors.js b/src/errors.js
@@ -45,6 +45,6 @@ export class UploadIncompleteError extends ExtendableError {
 
 export class InvalidChunkSizeError extends ExtendableError {
   constructor (chunkSize) {
-    super(`Invalid chunk size ${chunkSize}, must be a multiple of 256`)
+    super(`Invalid chunk size ${chunkSize}, must be a multiple of 256 and be 262144 or greater`)
   }
 }
diff --git a/test/functional-tests.js b/test/functional-tests.js
@@ -23,7 +23,7 @@ describe('Functional', () => {
       url: url || '/file',
       chunkSize: 256,
       file: makeFile(file)
-    })
+    }, true)
     await upload.start()
     requests = getRequests()
     return upload