Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #446 and #453 #456

Merged
merged 10 commits into from Feb 11, 2016
Merged

Fix for #446 and #453 #456

merged 10 commits into from Feb 11, 2016

Conversation

in3otd
Copy link
Contributor

@in3otd in3otd commented Feb 7, 2016

lot of small stuff here,

  • implemented changing the Qucs Home without restarting: it's a bit hackish but seems to work. Should have divided the "close all open files" and "prepare a new empty schematic and reload the projects tree" into two separate functions and maybe added a QMessageBox to inform the user.
  • changed the non-native file dialogs (there were several).
  • corrected handling the "Task" and "Comment" colors which has never been properly saved/loaded. They seem actually unused, though 馃槙
  • fixed the crash when changing background color of a Text Document, Crash when changing background color of text document聽#453
  • corrected the behaviour of "Add Path With Subfolders", see Change in Qucs Home requires restart.聽#446
  • removed the remaining inherits() used to determine if a widget was a TextDoc or a Schematic, used a static function defined in QucsApp instead. Confirmed that also the simulation of a text document was crashing due to the wrong check.
  • removed the deprecated Qt3 compatibility functions in in qucssettingsdialog.cpp; could have been done a bit more cleanly but lacked time...

Tried to check everything, seems to work here, please double check there also, thanks.

When changing a text documents background color (using the Application
Settings dialog) Qucs crashed. This was due to the changed inheritance
of TextDoc, from QTextEdit to QPlainTextEdit, which was not updated
here.
Not sure it's the right way, but it works now...
In the Application Settings dialog, the "Add Path With Subfolders"
added only the subfolders but not the selected path. Now also the
selected path is added to the list.
If user changes the Qucs (projects) Home in the Application Settings
Dialog, it will be prompted to close the current files/project (if
saving is needed).
@in3otd
Copy link
Contributor Author

in3otd commented Feb 8, 2016

? AppVeyor fails with

./.libs/lt-admsXml.c:315:19: error: '_P_WAIT' undeclared (first use in this function)
rval = _spawnv (_P_WAIT, lt_argv_zero, (const char * const *) newargz);
^

also #458 .

EDIT: added 0.0.19 label, since at least 9a1eada should go in to fix the GUI crashes

@in3otd in3otd added this to the 0.0.19 milestone Feb 8, 2016
@guitorri
Copy link
Member

guitorri commented Feb 9, 2016

Related to unused QSettings, this is now #460

@guitorri
Copy link
Member

Thank you @in3otd.
The background color now works for the schematic and text documents. Bug or feature?
Perhaps we should allow two colors? Or just white for the text document...

Ignore AppVeyor for the moment.... they updated something that broke something else I don't yet understand...

@in3otd
Copy link
Contributor Author

in3otd commented Feb 10, 2016

The background color now works for the schematic and text documents. Bug or feature?

well, since the original code tried to set the text documents background color to QucsSettings.BGColor (but didn't work), I made it actually work as intended. I think we may call it a feature 馃榿

But we can certainly have two different background colors for the two document types, in 0.0.20 or later...

@guitorri
Copy link
Member

Fair enough.
I build it locally on windows. We can skip the AppVeyor issue for the moment.
Thank you!

guitorri added a commit that referenced this pull request Feb 11, 2016
@guitorri guitorri merged commit e232abd into Qucs:master Feb 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants