New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #446 and #453 #456
Conversation
When changing a text documents background color (using the Application Settings dialog) Qucs crashed. This was due to the changed inheritance of TextDoc, from QTextEdit to QPlainTextEdit, which was not updated here.
Not sure it's the right way, but it works now...
In the Application Settings dialog, the "Add Path With Subfolders" added only the subfolders but not the selected path. Now also the selected path is added to the list.
If user changes the Qucs (projects) Home in the Application Settings Dialog, it will be prompted to close the current files/project (if saving is needed).
Related to unused QSettings, this is now #460 |
Thank you @in3otd. Ignore AppVeyor for the moment.... they updated something that broke something else I don't yet understand... |
well, since the original code tried to set the text documents background color to But we can certainly have two different background colors for the two document types, in 0.0.20 or later... |
Fair enough. |
lot of small stuff here,
QMessageBox
to inform the user.inherits()
used to determine if a widget was aTextDoc
or aSchematic
, used a static function defined inQucsApp
instead. Confirmed that also the simulation of a text document was crashing due to the wrong check.qucssettingsdialog.cpp
; could have been done a bit more cleanly but lacked time...Tried to check everything, seems to work here, please double check there also, thanks.