Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass refactoring. #8

Open
jpittis opened this issue Mar 31, 2015 · 6 comments
Open

Mass refactoring. #8

jpittis opened this issue Mar 31, 2015 · 6 comments

Comments

@jpittis
Copy link
Contributor

jpittis commented Mar 31, 2015

Let's make the code base a little less sketchy?

@MaxBittker
Copy link
Contributor

we could do a code review tomorrow 👍

@mystor
Copy link
Member

mystor commented Mar 31, 2015

I was looking it over today, and it's not as sketchy as I was expecting it
to be after how little sleep we got. We could certainly improve it in a few
places, though I don't want to go overboard.

On Mon, Mar 30, 2015 at 11:40 PM, Max Bittker notifications@github.com
wrote:

we could do a code review tomorrow :P


Reply to this email directly or view it on GitHub
#8 (comment).

@epilk
Copy link
Contributor

epilk commented Mar 31, 2015

Sure, lets also make a branch where we can start refactoring and breaking stuff?

@jpittis
Copy link
Contributor Author

jpittis commented Mar 31, 2015

Maybe lets talk tomorrow about features so we don't refactor anything we're planning to scrap.

@epilk
Copy link
Contributor

epilk commented Mar 31, 2015

yep, come to think about it, merging will be a big pain if we branch and devolpement continues in master. maybe we should just do it iteratively.

@jpittis
Copy link
Contributor Author

jpittis commented Mar 31, 2015

Every time you add a feature, make the code base a little nicer than the time before! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants