Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Xiangqi #93

Merged
merged 19 commits into from
Apr 27, 2021
Merged

Add support for Xiangqi #93

merged 19 commits into from
Apr 27, 2021

Conversation

mlanher
Copy link
Contributor

@mlanher mlanher commented Apr 26, 2021

Note these very hacky situations:

engine/3rdparty/Fairy-Stockfish/position.h

  • Added class FairyBoard as friend to Position

engine/3rdparty/Fairy-Stockfish/ucioption.cpp

  • Commented out option "Threads"

engine/src/uci/variants.h

  • Added !!!hardcoded!!! SUBVARIANT_NB iff XIANGQI is active

Also note the following:

engine/src/environments/fairy_state/fairyinputrepresentation.cpp

  • set_bits_from_bitmap inconsistent with CrazyAra as boards in data set were preprocessed in different order:
    First index equals upper left corner from view of red player

engine/3rdparty/Fairy-Stockfish/evaluate.h

  • You have to set the name of the .nnue file

Finally the following dependency has been added for preprocessing of csv data sets for Xiangqi:

Pandas

@QueensGambit
Copy link
Owner

Thanks a lot for this PR.
Please have a look at the broken continuous integration:

mlanher and others added 7 commits April 27, 2021 08:14
added init()
uncomment init()
use model/xiangqi as Model_Directory
use MODE_CRAYZHOUSE as default
@QueensGambit QueensGambit merged commit 5e5eee5 into QueensGambit:master Apr 27, 2021
@QueensGambit
Copy link
Owner

I fixed the remaining issues.
Thanks again for your great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants