Vehicle destroy and damage levels, hax siren and headlights #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinGruber
requested changes
Jun 23, 2021
| @@ -28,6 +28,13 @@ const modelToName = require("../../../data/2015/sampleData/ModelToName.json"); | |||
| const _ = require("lodash"); | |||
| const debug = require("debug")("zonepacketHandlers"); | |||
|
|
|||
| let vehicleState = 0; | |||
There was a problem hiding this comment.
why creating them that up in the file ? Like that these values will almost never get cleared from memory, you should define them right before the switch case where they are used
| delete client.mountedVehicle; | ||
| vehicleState = 0; | ||
| client.isPolice = false; | ||
| } else if (vehicleState === 500) { |
There was a problem hiding this comment.
you should use a switch for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its for singleplayer only, so i based the "health" on adding value to a variable and didnt bother about seperate health for multiple vehicles. If we apply siren or headlights then we cant turn them off, for that we need a proper effect packet, as well as for it to work in multiplayer.
I based my work on master branch cause i had problems with /hax drive on dev