Adapt accountability results filter for responsive view #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update translations in scope filter small partial * Normalize locales
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
As a user when navigating on the accountability results on responsive display, scopes filter can expand on a large part of screen.
This PR implements a scope selector for the responsive display and keeps the orignal scopes filter for the desktop display.
📌 Related Issues
Testing
http://localhost:3000/processes/[YOUR_PP]/f/15/results📷 Screenshots
Desktop view
Responsive view
Additional context
I don't know if I should add some tests for responsive view since I didn't find responsive view tests in project