Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#26 memoization fix #27

Merged
merged 2 commits into from
May 19, 2021
Merged

#26 memoization fix #27

merged 2 commits into from
May 19, 2021

Conversation

Quernest
Copy link
Owner

Replaced the returned new function with useCallback

@Quernest Quernest self-assigned this May 18, 2021
@Quernest Quernest added the bug Something isn't working label May 18, 2021
@Quernest Quernest linked an issue May 18, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #27 (4040452) into master (8e1c0d7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #27   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          115       114    -1     
  Branches        16        16           
=========================================
- Hits           115       114    -1     
Impacted Files Coverage Δ
src/useModal.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e1c0d7...4040452. Read the comment docs.

@Quernest Quernest merged commit a257e08 into master May 19, 2021
@Quernest Quernest deleted the 26 branch May 19, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 showModal hook returned by useModal is not properly memoized
1 participant