Add initial capacity to List and Compound tags #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Intellij autoformatter did some extra changes, let me know if you want me to revert them or its fine to leave them as is :) |
Marcono1234
reviewed
Apr 16, 2021
urielsalis
force-pushed
the
add-initial-capacity
branch
from
582f829
to
0fc12da
Compare
Marcono1234
reviewed
Apr 19, 2021
Co-authored-by: Marcono1234 <Marcono1234@users.noreply.github.com>
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
While running some profiling test on some high performance code using the library we found some simple optimizations :)
Problem
Resizing the backing collections for CompoundTag and ListTag can be expensive(Its a O(N) operation)
Goal
Add initial capacity constructors to both classes, so if you already know the size you can create it directly with that size and avoid the resizing :D
Implementation
Add new constructors that set the initial capacity
Caveats
None.
Further considerations
None.
ToDo list
None.