Force isRunning flag to be not null #668

SQL error on "Is Running" uncheck fixed QE ver 2.5.3
Quick-Event · Jan 16, 2022 · b7d6dab · b7d6dab
1 parent 1c07236
commit b7d6dab
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/libqf/libqfcore/src/model/tablemodel.cpp b/libqf/libqfcore/src/model/tablemodel.cpp
@@ -300,7 +300,7 @@ bool TableModel::setData(const QModelIndex &index, const QVariant &value, int ro
 	}
 	else if(role == Qt::CheckStateRole) {
 		//qfInfo() << __LINE__;
-		bool chk_val = (value.toInt() == Qt::Unchecked)? 0: 1;
+		bool chk_val = (value.toInt() != Qt::Unchecked);
 		ret = setValue(index.row(), index.column(), chk_val);
 		if(ret)
 			emit dataChanged(index, index);

diff --git a/quickevent/app/quickevent/plugins/Runs/src/cardflagsdialog.ui b/quickevent/app/quickevent/plugins/Runs/src/cardflagsdialog.ui
@@ -6,7 +6,7 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>299</width>
+    <width>363</width>
     <height>195</height>
    </rect>
   </property>
@@ -17,14 +17,17 @@
    <item>
     <widget class="QCheckBox" name="cbxCardLent">
      <property name="text">
-      <string>Card rent requested</string>
+      <string>Card rented / rent requested</string>
      </property>
     </widget>
    </item>
    <item>
     <widget class="QCheckBox" name="cbxCardInLentTable">
+     <property name="toolTip">
+      <string>Card exists in cards to rent table, see Competitors-&gt;Cards-&gt;Cards to rent</string>
+     </property>
      <property name="text">
-      <string>Card in rent cards table</string>
+      <string>Card rented from rent table</string>
      </property>
     </widget>
    </item>

diff --git a/quickevent/app/quickevent/plugins/Runs/src/runstablemodel.cpp b/quickevent/app/quickevent/plugins/Runs/src/runstablemodel.cpp
@@ -127,7 +127,7 @@ bool RunsTableModel::setValue(int row_ix, int column_ix, const QVariant &val)
 				return false;
 			}
 		}
-		return Super::setValue(row_ix, column_ix, is_running? is_running: QVariant());
+		return Super::setValue(row_ix, column_ix, is_running);
 	}
 	if(column_ix == col_runs_finishTimeMs) {
 		QVariant start_ms = value(row_ix, col_runs_startTimeMs);

diff --git a/quickevent/app/quickevent/src/appversion.h b/quickevent/app/quickevent/src/appversion.h
@@ -1,4 +1,4 @@
 #pragma once
 
-#define APP_VERSION "2.5.2"
+#define APP_VERSION "2.5.3"