Add specificity to css selectors #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrismd
reviewed
Oct 23, 2017
src/utils/getComponentCssSelector.js
Outdated
| */ | ||
| export default function getComponentCssSelector(componentName: string, options: Object) { | ||
| if (options && options.specificityClass) { | ||
| return `.${options.specificityClass} .${componentName}` |
There was a problem hiding this comment.
I'd like to see us support more than one specificityClass... can we support an array here? While we think one level of increased specificity is enough for our purposes now, we don't know for certain and other consumers of the framework may need it as well.
There was a problem hiding this comment.
As mentioned in the related PR, these are usually called "namespace classes". Perhaps that terminology would be more clear.
genedwards
approved these changes
Oct 23, 2017
|
Yeah, when we open a PR on the real repository, we need to make certain we aren't pushing lint-induced changes. |
nvanselow
commented
Oct 23, 2017
| unsubscribeFromContext() { | ||
| if (this.unsubscribeId !== -1) { | ||
| this.context[CHANNEL_NEXT].unsubscribe(this.unsubscribeId) | ||
| const createBaseStyledComponent = (options: Object) => { |
There was a problem hiding this comment.
This diff is still really bad. I tried a second time.
harrismd
reviewed
Oct 23, 2017
| let namespaceClass = options.namespaceClasses | ||
| if (Array.isArray(options.namespaceClasses)) { | ||
| namespaceClass = options.namespaceClasses.join(' .') | ||
| } |
harrismd
approved these changes
Oct 23, 2017
nvanselow
force-pushed
the
Add_specificity_to_css_selectors
branch
from
4fdffa6
to
6c21bb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the specificity of the css selector for a styled component to be modified through the options.
It passes through the options to the BaseStyledComponent so that it can call the css
generateAndInjectStyleswith the options. The specificityClass is set in options and used to increase the specificity of all classes.This works with QuickBase/babel-plugin-styled-components#1 to apply the options through babel.