Merge pull request #64 from quickbirdstudios/fix/pageCoordinator-memo…

…ry-leaks PageCoordinator memory leaks
QuickBirdEng · Feb 3, 2019 · d295b4c · d295b4c
2 parents 842ea31 + 4a580fe
commit d295b4c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/XCoordinator.podspec b/XCoordinator.podspec
@@ -1,6 +1,6 @@
 Pod::Spec.new do |spec|
     spec.name         = 'XCoordinator'
-    spec.version      = '1.2.3'
+    spec.version      = '1.2.4'
     spec.license      = { :type => 'MIT' }
     spec.homepage     = 'https://github.com/quickbirdstudios/XCoordinator'
     spec.authors      = { 'Stefan Kofler' => 'stefan.kofler@quickbirdstudios.com', 'Paul Kraft' => 'pauljohannes.kraft@quickbirdstudios.com' }

diff --git a/XCoordinator/Classes/PageCoordinator.swift b/XCoordinator/Classes/PageCoordinator.swift
@@ -29,7 +29,7 @@ open class PageCoordinator<RouteType: Route>: BaseCoordinator<RouteType, PageTra
             return
         }
 
-        super.init(initialTransition: .set(firstPage, direction: direction))
+        super.init(initialTransition: .multiple(.initial(pages: pages), .set(firstPage, direction: direction)))
     }
 
     // MARK: - Overrides

diff --git a/XCoordinator/Classes/PageTransition.swift b/XCoordinator/Classes/PageTransition.swift
@@ -22,4 +22,15 @@ extension Transition where RootViewController: UIPageViewController {
             }
         }
     }
+
+    static func initial(pages: [Presentable]) -> Transition {
+        return Transition(presentables: pages, animation: nil) { _, performer, completion in
+            CATransaction.begin()
+            CATransaction.setCompletionBlock {
+                pages.forEach { $0.presented(from: performer) }
+                completion?()
+            }
+            CATransaction.commit()
+        }
+    }
 }