Feature survey result to json #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 12, 2022 18:02
fixes issue with running build_runner after DoubleAnswer was renamed to MultiDouble
- instead of manually overriding operator == and hashCode one by one
Notes: - IMPORTANT: when adding new Result subclasses, update the _Converter function in step_result.dart accordingly. The toJson and fromJson functions there output and parse "type" field in order to distinguish between the different subclasses by that (rather than relying on heuristics in the result data field) - the name of the result propery had to be streamlined in subclasses, e.g. instead of MultiDoubleQuestionResult.results and VideoStepResult.videoResult it's now .result - and the explicitToJson option had to be added for the generation to work
- instruction, completion and video step results were missing - implicit cast wrongly returned List<Result> instead List<QuestionResult> - minor fix in a test + added a new case for SurveyResult level
adar2378
added a commit
to djangoflow/survey_kit
that referenced
this pull request
Aug 18, 2022
Feature survey result to json (QuickBirdEng#81)
Closed
|
is the results toJson() function not yet implemented on the released version? is it coming on version 2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added json serialisation for the SurveyResult
Implements #79
Relevant to #39 and #69
Happy to discuss :)