Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project defaults to TLS 1.0 #5

Closed
Alkaersig opened this issue Jul 3, 2018 · 1 comment
Closed

Project defaults to TLS 1.0 #5

Alkaersig opened this issue Jul 3, 2018 · 1 comment

Comments

@Alkaersig
Copy link

Currently the project targets .NET 4.5 which defaults to TLS 1.0. Unless this is overwritten, requests made by the client will be blocked by QuickPay servers since deprecation of TLS 1.0.

As a minimum the documentation should be updated to reflect this.

I tried downloading the project, update the target framework to .NET 4.5.2 and updating RestSharp to the newest version which adds support for .NET Standards 2.0 and .NET Core 2.0 (which has been asked in another issue).

Then executing:
System.Net.ServicePointManager.SecurityProtocol = SecurityProtocolType.Tls12
before any calls are made forces the use of TLS 1.2.

This is not best practice as this enforces TLS 1.2 and not future implementations, but using .NET Framework 4.5 this is probably the best solution enforcing TLS 1.1+ is not handled server side, which for many hosts it is not.

Updating the project to target .NET 4.7 (i'm not sure whether this is possible with the current version of RestSharp as i have not looked into it) will also solve the problem as the strongest possible encryption will be chosen automatically.

See:
https://docs.microsoft.com/en-us/dotnet/framework/network-programming/tls
https://blogs.perficient.com/2016/04/28/tsl-1-2-and-net-support/

@objecta
Copy link
Collaborator

objecta commented Aug 21, 2018

The QP Client lib has been updated to use .NET 4.6.2 to support TLS 1.2 by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants