Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prepare API #22

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Add Prepare API #22

merged 4 commits into from
Nov 29, 2023

Conversation

RichLogan
Copy link
Contributor

Adds a prepare API whereby a sequence number can be submitted to call any appropriate concealment callbacks in order to make the buffer ready for the Enqueue of said sequence number's packet data. This is useful when your concealment is stateful and you need it to be generated before you decode your to-be-enqueued data.

For example:

  • Packet 1 has arrived, been decoded and Enqueue'd into the buffer
  • Packet 3 just arrived.
  • Call Prepare(3) to generate and enqueue missing packet 2
  • Now we are in a state where 3 can be decoded and Enqueue'd

Copy link
Contributor

@GhostofCookie GhostofCookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good!

JitterBuffer.cpp Outdated Show resolved Hide resolved
@RichLogan RichLogan merged commit 10ac828 into main Nov 29, 2023
1 check passed
@RichLogan RichLogan deleted the prepare branch November 29, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants