Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(international-types): flatten works with dot & object notation #236

Merged
merged 2 commits into from
Oct 10, 2023
Merged

fix(international-types): flatten works with dot & object notation #236

merged 2 commits into from
Oct 10, 2023

Conversation

QuiiBz
Copy link
Owner

@QuiiBz QuiiBz commented Oct 10, 2023

Closes #197

FlattenLocale should work when a locale is using both dot & object notation:

Before After
Screenshot 2023-10-10 at 09 35 05l Screenshot 2023-10-10 at 09 35 28

@QuiiBz QuiiBz added the bug Something isn't working label Oct 10, 2023
@vercel
Copy link

vercel bot commented Oct 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-international ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 8:37am

@QuiiBz QuiiBz merged commit f784bbd into main Oct 10, 2023
6 checks passed
@QuiiBz QuiiBz deleted the fix/international-types-flatten-both branch October 10, 2023 08:38
@QuiiBz QuiiBz mentioned this pull request Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect typescript types for parameters using dot notation
1 participant
@QuiiBz