perf(next-international): optimize middleware #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @QuiiBz on Vercel. @QuiiBz first needs to authorize it. |
QuiiBz
requested changes
Nov 20, 2023
| if (noLocalePrefix(config.locales, requestUrl.pathname)) { | ||
| requestUrl.pathname = `/${locale}${requestUrl.pathname}`; | ||
| // If the locale from the request is not an handled locale, then redirect to the same URL with the default locale | ||
| if (!hasHandledLocale(config.locales, nextUrl.pathname)) { |
There was a problem hiding this comment.
Not a fan of the updated function name + the negation. Could we revert the changes?
QuiiBz
approved these changes
Nov 21, 2023
QuiiBz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String.prototype.splitparam #238, when the URL are becoming long like https://github.com/QuiiBz/next-international/issues/..., there will be no loss of performance.redirectpart but I'm not sure it's easy to read and understand this part so don't hesitate to give your opinion.localeFromRequestfunction, there were several assignments that weren't necessary, so I merged them.clone()call (fromnextUrl) because it creates a new instance and it seems to be no longer documented on the doc, only on error messages